feat(opentelemetry-instrumentation-aiokafka): wrap getone instead of anext, add tests #2874
+297
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimastbk
changed the title
xrmx
reviewed
Sep 17, 2024
|
|
||
| class TestAIOKafka(TestCase): | ||
| def test_instrument_api(self) -> None: |
There was a problem hiding this comment.
I'm not sure you can keep async and sync tests on the same class. In the past I've fixed cases where the tests were not running and warnings were written in the console
There was a problem hiding this comment.
Hm. I've never encountered this, but I divided it into two test classes.
xrmx
reviewed
Sep 17, 2024
| @@ -126,10 +126,10 @@ def _instrument(self, **kwargs): | |||
| ) | |||
| wrap_function_wrapper( | |||
| aiokafka.AIOKafkaConsumer, | |||
| "__anext__", | |||
| _wrap_anext(tracer, async_consume_hook), | |||
| "getone", | |||
There was a problem hiding this comment.
Why are we changing the wrapped function?
There was a problem hiding this comment.
anext evaluate getone under the hood, and getone can be used directly.
|
Would you mind adding yourself to component_owners.yml according to CONTRIBUTING.MD |
|
@lzchen done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrap getone instead of anext
Add tests for opentelemetry-instrumentation-aiokafka (#2082)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.