Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(opentelemetry-instrumentation-aiokafka): wrap getone instead of anext, add tests #2874

Merged
merged 12 commits into from
Sep 26, 2024
Merged

feat(opentelemetry-instrumentation-aiokafka): wrap getone instead of anext, add tests #2874

merged 12 commits into from
Sep 26, 2024

Conversation

dimastbk
Copy link
Contributor

@dimastbk dimastbk commented Sep 16, 2024 •
edited
Loading

Description

Wrap getone instead of anext
Add tests for opentelemetry-instrumentation-aiokafka (#2082)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Does This PR Require a Core Repo Change?

  • Yes.
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@dimastbk dimastbk changed the title test: add tests for opentelemetry-instrumentation-aiokafka feat(opentelemetry-instrumentation-aiokafka): wrap getone instead of anext, add tests Sep 17, 2024
@dimastbk dimastbk marked this pull request as ready for review September 17, 2024 06:26
@dimastbk dimastbk requested a review from a team September 17, 2024 06:26
@lzchen
Copy link
Contributor

lzchen commented Sep 18, 2024

@dimastbk

Would you mind adding yourself to component_owners.yml according to CONTRIBUTING.MD

@dimastbk
Copy link
Contributor Author

@lzchen done

@emdneto emdneto requested a review from a team as a code owner September 19, 2024 22:11
emdneto
emdneto reviewed Sep 19, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
xrmx
xrmx approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It adds more tests than code so it can't be wrong

@xrmx xrmx enabled auto-merge (squash) September 26, 2024 12:55
@xrmx xrmx merged commit d52f42f into open-telemetry:main Sep 26, 2024
528 checks passed
@dimastbk dimastbk deleted the aiokafka branch September 26, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdneto emdneto emdneto approved these changes

@xrmx xrmx xrmx approved these changes

@nemoshlag nemoshlag Awaiting requested review from nemoshlag

Assignees

@dimastbk dimastbk

@nemoshlag nemoshlag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dimastbk @lzchen @xrmx @emdneto @nemoshlag