GenAI Utils | Add more SemConv Attributes #3862
Open
+306
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Draft
3 tasks
zhirafovod
approved these changes
Oct 28, 2025
lmolkova
approved these changes
Oct 28, 2025
| _maybe_set_span_messages( | ||
| span, invocation.input_messages, invocation.output_messages | ||
| ) | ||
| _apply_request_attributes(span, invocation) |
There was a problem hiding this comment.
not blocking for this PR, but we should eventually allow to set attributes at start time. I noticed we don't properly mark which attributes should be provided at the start time, fixing it in the open-telemetry/semantic-conventions#2994
| else: | ||
| finish_reasons = None | ||
|
|
||
| if finish_reasons: |
There was a problem hiding this comment.
I believe if finish_reasons is not available, we should set error - open-telemetry/semantic-conventions#2919 (comment)
util/opentelemetry-util-genai/src/opentelemetry/util/genai/types.py
Outdated
Show resolved
Hide resolved
aabmass
reviewed
Oct 30, 2025
|
|
||
| from dataclasses import asdict | ||
| from typing import List | ||
| from typing import Any, Dict, List, Optional |
There was a problem hiding this comment.
nit prefer to use dict[k, v], and Foo | None with from __future__ import annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing SemConv attributes to spans for LLMInvocation calls, clean up some repeated code in the unit tests for genai utils.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Updated unit tests to check for additional attributes
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.