Replace asyncio.iscoroutinefunction with inspect.iscoroutinefunction

[phillipuniverse]

Description

asyncio.iscoroutinefunction is officially deprecated in 3.14, inspect.iscoroutinefunction has been around since 3.5

Fixes #3879

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A

Does This PR Require a Core Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[xrmx]

This breaks something, could you please take a look at the failing tests?

[phillipuniverse]

Yup I’ll fix!

[phillipuniverse]

Hm the failing test is a bug in CPython where an AsyncMock fails inspect.iscoroutinefunction(), but asyncio.iscoroutinefunction() works. However, it appears that fix was only backported to Python 3.10+ (specifically 3.10.6+), so 3.9 still has the problem.

Here's a debug session that shows live variables and illustrates the problem:

I guess we could special case for Python 3.9, but I assume in the near term otel will drop Python 3.9 compatibility since it's EOL? The particularly annoying part is that this only shows up in AsyncMock on Python 3.9 and wouldn't show up in real runtime cases...

Our options as I see it:

1. Special case this tests for aiokafka to work around this problem
2. Don't accept this change until otel drops Python 3.9 code
3. Add if sys.version_info < 3.9 to the iscoroutunction check to either use asyncio or inspect modules

I kind of think we should do (1)

[phillipuniverse]

@xrmx I added what I think is a reasonable fix given the Python 3.9 status, LMK if you'd like a different change!