-
Notifications
You must be signed in to change notification settings - Fork 829
opentelemetry-instrumentation-aiohttp-client: add type checking support #4006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
opentelemetry-instrumentation-aiohttp-client: add type checking support #4006
Conversation
| _set_http_peer_port_client, | ||
| _set_http_url, | ||
| _set_status, | ||
| _set_http_host_client, # type: ignore[reportUnknownVariableType] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we avoid adding these ignore if opentelemetry.instrumentation._semconv had more type hints added to it first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially wanted to scope the changes just to aiohttp-client, but I can certainly add typing here too to address the point you're making
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated all the typing inside opentelemetry.instrumentation._semconv :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and sorry for scope creep. I figured it would help for the other instrumentors later that also use _semconv
|
@herin049 If you are using |
Absolutely. We use |
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you this is quite helpful!
ee3d706 to
2970295
Compare
2970295 to
417f1a2
Compare
Update the PR to include myself as a component owner for |
Description
Add type checking support for the
opentelemetry-aiohttp-clientpackage.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e typecheckDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.