nits

open-telemetry · Sep 27, 2023 · 6e61be6 · 6e61be6
1 parent 34a5545
commit 6e61be6
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/opentelemetry-sdk/tests/trace/test_trace.py b/opentelemetry-sdk/tests/trace/test_trace.py
@@ -661,7 +661,7 @@ def test_attributes(self):
             root.set_attribute("list-of-numerics", list_of_numerics)
 
             self.assertEqual(len(root.attributes), 9)
-            self.assertEqual(root.attributes["http.method"], "GET")
+            self.assertEqual(root.attributes["http.request.method"], "GET")
             self.assertEqual(
                 root.attributes["url.full"],
                 "https://example.com:779/path/12/?q=d#123",

diff --git a/opentelemetry-semantic-conventions/src/opentelemetry/semconv/trace/__init__.py b/opentelemetry-semantic-conventions/src/opentelemetry/semconv/trace/__init__.py
@@ -1353,6 +1353,11 @@ class SpanAttributes:
     Deprecated. Use `client.address` attribute.
     """
 
+    HTTP_FLAVOR = "http.flavor"
+    """
+    Deprecated. Use `network.protocol.name` and `network.protocol.version` attributes.
+    """
+
     NET_HOST_CONNECTION_TYPE = "net.host.connection.type"
     """
     Deprecated. Use `network.connection.type` attribute.

diff --git a/scripts/semconv/generate.sh b/scripts/semconv/generate.sh
@@ -10,7 +10,7 @@ OTEL_SEMCONV_GEN_IMG_VERSION=0.21.0
 
 cd ${SCRIPT_DIR}
 
-rm -rf semantic-c || true
+rm -rf semantic-conventions || true
 mkdir semantic-conventions
 cd semantic-conventions
 

diff --git a/scripts/semconv/templates/semantic_attributes.j2 b/scripts/semconv/templates/semantic_attributes.j2
@@ -79,14 +79,14 @@ class {{class}}:
         "http.request_content_length_uncompressed"
     )
     """
-    Deprecated, use the `http.request_content_length` attribute.
+    Deprecated, use the `http.request.body.size` attribute.
     """
 
     HTTP_RESPONSE_CONTENT_LENGTH_UNCOMPRESSED = (
         "http.response_content_length_uncompressed"
     )
     """
-    Deprecated, use the `http.response_content_length` attribute.
+    Deprecated, use the `http.response.body.size` attribute.
     """
 
     MESSAGING_DESTINATION = "messaging.destination"
@@ -164,6 +164,11 @@ class {{class}}:
     Deprecated. Use `client.address` attribute.
     """
 
+    HTTP_FLAVOR = "http.flavor"
+    """
+    Deprecated. Use `network.protocol.name` and `network.protocol.version` attributes.
+    """
+
     NET_HOST_CONNECTION_TYPE = "net.host.connection.type"
     """
     Deprecated. Use `network.connection.type` attribute.