fix: re-enabled skipping over native logrecord attributes again that …

…aren't covered by a semantic convention and ran black
open-telemetry · Jul 4, 2024 · 79ce99a · 79ce99a
1 parent 0552590
commit 79ce99a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 13 deletions.
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
@@ -57,7 +57,7 @@
 _DEFAULT_OTEL_ATTRIBUTE_COUNT_LIMIT = 128
 _ENV_VALUE_UNSET = ""
 _EXCLUDED_ATTRIBUTES = {
-    # pseudo-private log-record attributes, they just get dropped
+    # pseudo-private log-record attributes, they should always be dropped
     "args",
     "msg",
     "message",
@@ -71,6 +71,19 @@
     "lineno",
     "thread",
     "threadName",
+    # attributes that are omitted because no semantic convention exists for them yet
+    "asctime",
+    "created",
+    "filename",
+    "levelname",
+    "levelno",
+    "module",
+    "msecs",
+    "name",
+    "process",
+    "processName",
+    "relativeCreated",
+    "taskName",
 }
 
 

diff --git a/opentelemetry-sdk/tests/logs/test_handler.py b/opentelemetry-sdk/tests/logs/test_handler.py
@@ -255,20 +255,10 @@ def test_log_record_args_are_translated(self):
         self.assertEqual(
             set(log_record.attributes),
             {
+                "thread.id",
                 "code.filepath",
-                "code.function",
                 "code.lineno",
-                "created",
-                "filename",
-                "levelname",
-                "levelno",
-                "module",
-                "msecs",
-                "name",
-                "process",
-                "processName",
-                "relativeCreated",
-                "thread.id",
+                "code.function",
                 "thread.name",
             },
         )