Loosen googleapis-common-protos requirement in opentelemetry-exporter-otlp-proto-http #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
reviewed
Jun 23, 2023
| @@ -28,7 +28,7 @@ dependencies = [ | |||
| "Deprecated >= 1.2.6", | |||
| "backoff >= 1.10.0, < 2.0.0; python_version<'3.7'", | |||
| "backoff >= 1.10.0, < 3.0.0; python_version>='3.7'", | |||
| "googleapis-common-protos ~= 1.52", | |||
| "googleapis-common-protos ~= 1.52, < 1.60.0", | |||
There was a problem hiding this comment.
This is not loosening the requirement, this is making it more strict no? googleapis-common-protos ~= 1.52 already allows any 1.x version:
$ python3 -m venv venv
$ ./venv/bin/pip install 'googleapis-common-protos ~= 1.52'
$ ./venv/bin/pip list googleapis-common-protos
$ ./venv/bin/pip list
Package Version
------------------------ -------
googleapis-common-protos 1.59.1
pip 23.0.1
protobuf 4.23.3
setuptools 66.1.1
There was a problem hiding this comment.
Besides that, right now the latest version of googleapis-common-protos is 1.59.1.
What is this change actually trying to prevent? Seems like you expect an issue to happen when 1.60.0 is released?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loosen the upper bound on the
googleapis-common-protosrequirement to avoid unnecessary dependency conflicts with other libraries (e.g. more recent versions ofgoogle-api-core).Fixes # (issue)
Type of change
How Has This Been Tested?
Automated tests