Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dropped spans counter metric to catch number of dropped spans. #3386

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added dropped spans counter metric to catch number of dropped spans. #3386

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ac6dec
Added dropped spans counter metric to catch number of dropped spans.
rajat315315 Jul 19, 2023
4a036ae
Merge branch 'main' into dropped_counter
ocelotl Aug 7, 2023
4ee2e8a
reviewed code.
rajat315315 Aug 7, 2023
03ac794
Merge branch 'main' into dropped_counter
ocelotl Aug 10, 2023
376cbe8
Merge branch 'main' into dropped_counter
ocelotl Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion opentelemetry-sdk/src/opentelemetry/sdk/trace/export/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
)
from opentelemetry.sdk.trace import ReadableSpan, Span, SpanProcessor
from opentelemetry.util._once import Once
from opentelemetry.metrics import Meter

_DEFAULT_SCHEDULE_DELAY_MILLIS = 5000
_DEFAULT_MAX_EXPORT_BATCH_SIZE = 512
Expand Down Expand Up @@ -198,6 +199,7 @@ def __init__(
self.done = False
# flag that indicates that spans are being dropped
self._spans_dropped = False
self._dropped_spans_counter = None
# precallocated list to send spans to exporter
self.spans_list = [
None
Expand Down Expand Up @@ -228,7 +230,10 @@ def on_end(self, span: ReadableSpan) -> None:
if not self._spans_dropped:
logger.warning("Queue is full, likely spans will be dropped.")
self._spans_dropped = True

self._dropped_spans_counter = Meter.create_counter(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a bug here (not related to your change). self._spans_dropped should be reset to False after the queue has flushed some items. In this case, I would not rely on self._spans_dropped as the indicator of whether to create the counter, but instead if the counter exists already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are needed for this change.

name="dropped_spans_counter", description="Dropped Spans counter"
)
self._dropped_spans_counter.add(1)
self.queue.appendleft(span)

if len(self.queue) >= self.max_export_batch_size:
Expand Down
Loading