Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter: add is_remote_parent span flags to OTLP exported spans and links #3881

Merged
merged 3 commits into from
May 9, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Apr 26, 2024

Description

Set SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK when the span parent is remote.

Fixes #3876

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e py310-opentelemetry-exporter-otlp-proto-common-0

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team as a code owner April 26, 2024 10:43
@xrmx xrmx force-pushed the is_remote_parent_span_flag branch 3 times, most recently from 2935800 to b060c78 Compare April 29, 2024 19:12
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

…links

Set SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK when the span parent is remote.

Fixes open-telemetry#3876
@xrmx xrmx force-pushed the is_remote_parent_span_flag branch from 52f2d6f to c104651 Compare May 7, 2024 12:29
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Aaron Abbott <[email protected]>
@lzchen lzchen enabled auto-merge (squash) May 9, 2024 17:31
auto-merge was automatically disabled May 9, 2024 17:33

Pull Request is not mergeable

@lzchen lzchen merged commit 6e84b1f into open-telemetry:main May 9, 2024
233 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add is_remote_parent span flags to OTLP exported Spans and SpanLinks
4 participants