Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running mypy on SDK resources #3995

Closed
wants to merge 3 commits into from

Conversation

Medinatlawal
Copy link

@Medinatlawal Medinatlawal commented Jun 24, 2024

Part of #1608

Addressing running mypy on opentelemetry-sdk iteratively so we don't have to make one big change addressing all mypy issues at once.

@Medinatlawal
Copy link
Author

There's still about 7 errors left on resource file that I'm stuck on, if anyone can help with some advice on how to address them or know how that address them that'd be great! Alot of the leftover errors have to do with "Type"Any"".

@emdneto
Copy link
Member

emdneto commented Jun 27, 2024

Pasting errors here:

$ mypy --install-types --non-interactive --namespace-packages --explicit-package-bases opentelemetry-sdk/src/opentelemetry/sdk/resources

opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py:69: error: Module "opentelemetry.attributes" has no attribute "BoundedAttributes"  [attr-defined]
opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py:198: error: Expression has type "Any"  [misc]
opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py:199: error: Expression type contains "Any" (has type "Iterator[Any]")  [misc]
opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py:199: error: Expression type contains "Any" (has type "SupportsNext[Any]")  [misc]
opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py:286: error: Expression type contains "Any" (has type "dict[Any, Any]")  [misc]
opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py:373: error: Expression has type "Any"  [misc]
opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py:374: error: Expression has type "Any"  [misc]

asasvari pushed a commit to asasvari/opentelemetry-python that referenced this pull request Jul 13, 2024
Part of open-telemetry#1608

Addressing running mypy on opentelemetry-sdk iteratively so we don't have to make one big change addressing all mypy issues at once.
asasvari pushed a commit to asasvari/opentelemetry-python that referenced this pull request Jul 13, 2024
Part of open-telemetry#1608

Addressing running mypy on opentelemetry-sdk iteratively so we don't have to make one big change addressing all mypy issues at once.
asasvari added a commit to asasvari/opentelemetry-python that referenced this pull request Jul 13, 2024
Part of open-telemetry#1608

Addressing running mypy on opentelemetry-sdk iteratively so we don't have to make one big change addressing all mypy issues at once.
asasvari added a commit to asasvari/opentelemetry-python that referenced this pull request Jul 13, 2024
Part of open-telemetry#1608

Addressing running mypy on opentelemetry-sdk iteratively so we don't have to make one big change addressing all mypy issues at once.
xrmx pushed a commit to xrmx/opentelemetry-python that referenced this pull request Jul 26, 2024
Part of open-telemetry#1608

Addressing running mypy on opentelemetry-sdk iteratively so we don't have to make one big change addressing all mypy issues at once.
@lzchen
Copy link
Contributor

lzchen commented Jul 30, 2024

Superceded by #4053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants