Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional scope attribute for tracer creation #4028

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

optional scope attribute for tracer creation #4028

wants to merge 8 commits into from
+48 −3

Conversation

soumyadeepm04
Copy link
Contributor

Description

Fixes part of #2940

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • unit test added for sdk change

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@soumyadeepm04 soumyadeepm04 requested a review from a team as a code owner July 5, 2024 19:17
emdneto
emdneto reviewed Jul 6, 2024
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a changelog entry, and I think it's better to wait for #4015 since it's the PR which is introducing the attributes to InstrumentationScope

@xrmx xrmx marked this pull request as draft July 9, 2024 08:34
@xrmx
Copy link
Contributor

xrmx commented Jul 9, 2024

Converted to draft, please make it ready once #4015 has been merged

@xrmx xrmx marked this pull request as ready for review July 10, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdneto emdneto emdneto left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@soumyadeepm04 @xrmx @emdneto