Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grpc endpoint #4051

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix: grpc endpoint #4051

merged 2 commits into from
Jul 15, 2024

Conversation

horw
Copy link
Contributor

@horw horw commented Jul 12, 2024

Description

Hello!
Your tutorial was very helpful for me. I found that the new version of the collector no longer uses 0.0.0.0 as the default, so in this MR, I fixed it. You can find more information about the update at: https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.104.0

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@horw horw requested a review from a team as a code owner July 12, 2024 06:50
Copy link

linux-foundation-easycla bot commented Jul 12, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lzchen / name: Leighton Chen (23f21d6)
  • ✅ login: horw / name: Igor Udot (b6eaba0)

@horw
Copy link
Contributor Author

horw commented Jul 12, 2024

I suspect that many examples will have the same issue. If you agree, I can review and update other examples as well.

Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense since otel-collector in the latest version:

The otlpreceiver now uses localhost by default instead of 0.0.0.0

Care to fix the README as well?

@xrmx
Copy link
Contributor

xrmx commented Jul 13, 2024

Please also update docs/examples/metrics/instruments/otel-collector-config.yaml

@horw horw force-pushed the fix/grpc-endpoint branch 2 times, most recently from 41458cb to 4854d84 Compare July 13, 2024 11:21
@horw
Copy link
Contributor Author

horw commented Jul 13, 2024

@emdneto @xrmx Thanks, Updated!

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 15, 2024
@lzchen lzchen merged commit 5dbb385 into open-telemetry:main Jul 15, 2024
285 checks passed
emdneto pushed a commit to emdneto/opentelemetry-python that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants