opentelemetry-api: Allow importlib_metadata<=8.2
#4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Jul 29, 2024
Co-authored-by: Riccardo Magliocchetti <[email protected]>
antonpirker
changed the title
importlib_metadata<9importlib_metadata<=8.2
|
Retested in all Python versions, everything still green. |
xrmx
reviewed
Jul 30, 2024
xrmx
approved these changes
Jul 30, 2024
emdneto
approved these changes
Jul 30, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
importlib_metadatahad two minor releases in the last month. This PR will remove dependency conflicts for users that have the newest version ofimportlib_metadatain their dependencies.I changed the dependencies to allow all minor versions of
importlib_metadatauntil the next major version,and also update the
test-requirements.txtto always install the newest 8.x version ofimportlib_metadata.(At sentry we had a good experience with not pinning test requirements. Ok, once in a while someone does a release that breaks our tests, but at least we know right away that something is not working with a new version of a dependency)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Yes, ran those tests and everything is green:
tox -e py38-test-opentelemetry-apitox -e py39-test-opentelemetry-apitox -e py310-test-opentelemetry-apitox -e py311-test-opentelemetry-apitox -e py312-test-opentelemetry-apiDoes This PR Require a Contrib Repo Change?
Probably not. I am not sure.
opentelementry-instrumentation-aiohttp-serverandopentelementry-instrumentation-flaskuseimportlib_metadatabut there are no dependencies specified inopentelemetry-python-contribforimportlib_metadata.Checklist: