Accept non URL-encoded headers #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentm
approved these changes
Aug 2, 2024
xrmx
force-pushed
the
accept-non-urlencoded-headers
branch
from
cee9dc3
to
6a6830b
Compare
Add a liberal boolean parameter to parse_env_headers default to False to keep backward compatibility for the function. If liberal=True we try to parse the string even if it does comply with the the W3C Baggage HTTP header format to be more compatible with other other languages SDKs that accept non URL-encoded headers by default.
xrmx
force-pushed
the
accept-non-urlencoded-headers
branch
from
96e4db8
to
4ceb51d
Compare
lzchen
approved these changes
Aug 5, 2024
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this pull request
Aug 19, 2024
After open-telemetry#4103 we accept non url-encoded headers for OTLP. Naively this implementation only accepts digits, ascii letters, underscores (\w) and spaces. Instead broaden the accepted chars to what we accept for urlencoded values so that we accepts = to allow for base64 encoded values.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a liberal boolean parameter to parse_env_headers default to False to keep backward compatibility for the function.
If liberal=True we try to parse the string even if it does comply with the the W3C Baggage HTTP header format to be more compatible with other languages SDKs that accept non URL-encoded headers by default.
liberal is a reference to Postel's law.
Fixes #4102
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: