Skip to content

refactor: change error level logging to debug level for resource dete… #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: change error level logging to debug level for resource dete… #1540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d450b3
refactor: change error level logging to debug level for resource dete…
yiyuan-he May 16, 2025
27a7a12
Merge branch 'main' into update-debug-logging-aws-detectors
yiyuan-he May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/aws/lib/opentelemetry/resource/detector/aws/ec2.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def detect
resource_attributes[RESOURCE::HOST_TYPE] = identity['instanceType']
resource_attributes[RESOURCE::HOST_NAME] = hostname
rescue StandardError => e
OpenTelemetry.handle_error(exception: e, message: 'EC2 resource detection failed')
OpenTelemetry.logger.debug("EC2 resource detection failed: #{e.message}")
return OpenTelemetry::SDK::Resources::Resource.create({})
end

Expand Down Expand Up @@ -134,7 +134,7 @@ def make_request(uri, request)
http.request(request)
end
rescue StandardError => e
OpenTelemetry.handle_error(exception: e, message: 'EC2 metadata service request failed')
OpenTelemetry.logger.debug("EC2 metadata service request failed: #{e.message}")
nil
end
end
Expand Down
6 changes: 3 additions & 3 deletions resources/aws/lib/opentelemetry/resource/detector/aws/ecs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def detect
logs_attributes = get_logs_resource(container_metadata)
resource_attributes.merge!(logs_attributes)
rescue StandardError => e
OpenTelemetry.handle_error(exception: e, message: 'ECS resource detection failed')
OpenTelemetry.logger.debug("ECS resource detection failed: #{e.message}")
return OpenTelemetry::SDK::Resources::Resource.create({})
end

Expand All @@ -93,7 +93,7 @@ def fetch_container_id
end
end
rescue Errno::ENOENT => e
OpenTelemetry.handle_error(exception: e, message: 'Failed to get container ID on ECS')
OpenTelemetry.logger.debug("Failed to get container ID on ECS: #{e.message}")
end

''
Expand Down Expand Up @@ -140,7 +140,7 @@ def get_logs_resource(container_metadata)
log_attributes[RESOURCE::AWS_LOG_STREAM_NAMES] = [logs_stream_name].compact
log_attributes[RESOURCE::AWS_LOG_STREAM_ARNS] = [logs_stream_arn].compact
else
OpenTelemetry.handle_error(message: 'The metadata endpoint v4 has returned \'awslogs\' as \'LogDriver\', but there is no \'LogOptions\' data')
OpenTelemetry.logger.debug("The metadata endpoint v4 has returned 'awslogs' as 'LogDriver', but there is no 'LogOptions' data")
end
end

Expand Down
2 changes: 1 addition & 1 deletion resources/aws/lib/opentelemetry/resource/detector/aws/lambda.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def detect
# Convert memory size to integer
resource_attributes[RESOURCE::FAAS_MAX_MEMORY] = ENV['AWS_LAMBDA_FUNCTION_MEMORY_SIZE'].to_i if ENV['AWS_LAMBDA_FUNCTION_MEMORY_SIZE']
rescue StandardError => e
OpenTelemetry.handle_error(exception: e, message: 'Lambda resource detection failed')
OpenTelemetry.logger.debug("Lambda resource detection failed: #{e.message}")
return OpenTelemetry::SDK::Resources::Resource.create({})
end

Expand Down