feat: allow for propagation_style in Sidekiq instrumentation to have dynamic option #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hibachrach
force-pushed
the
make-sidekiq-propagation-style-dynamic
branch
2 times, most recently
from
6d698ab to
f568e48
Compare
…dynamic option This still permits static values (and environment variable to configure them) but allows users to opt-in to having a callable/dynamic value for the given option. Resolves open-telemetry#991
hibachrach
force-pushed
the
make-sidekiq-propagation-style-dynamic
branch
from
f568e48 to
c16cb5f
Compare
hibachrach
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
|
FYI, I opted to change the config handling code to allow for more complex config value types, but happy to add a new callable config option that would take precedent over the current enum value instead and revert all of that. Not sure which would be preferred. |
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still permits static values (and environment variable to configure them) but allows users to opt-in to having a callable/dynamic value for the given option.
Resolves #991