feat!: deprecate sql-obfuscation gem #1674
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
changed the title
hannahramadan
commented
Sep 16, 2025
| require_relative 'opentelemetry/helpers' | ||
|
|
||
| OpenTelemetry.logger.warn <<~WARNING | ||
| [DEPRECATION] The 'opentelemetry-helpers-sql-obfuscation' gem has been renamed to 'opentelemetry-helpers-sql-processor'. No action is needed unless you use this gem directly. |
There was a problem hiding this comment.
This warning shows up when using instrumentation uses sql-obfuscation
WARN -- : [DEPRECATION] The 'opentelemetry-helpers-sql-obfuscation' gem has been renamed to 'opentelemetry-helpers-sql-processor'. No action is needed unless you use this gem directly.
There was a problem hiding this comment.
While we could add a post install message in the gemspec, I like the implications that come with using logger's warn.
This was referenced Sep 16, 2025
hannahramadan
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
xuan-cao-swi
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecating
opentelemetry-helpers-sql-obfuscationin favor ofopentelemetry-helpers-sql-processorThis should be merged 2nd in a series of 3 PRs:
After this final version is released, we can delete this directory from a future release.