Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1835 +/- ##
=====================================
Coverage 75.0% 75.0%
=====================================
Files 122 122
Lines 20279 20279
=====================================
+ Hits 15211 15212 +1
+ Misses 5068 5067 -1 ☔ View full report in Codecov by Sentry. |
|
@lalitb @TommyCpp please take a look at the changes when you get a chance. I had to disable the call to serialize My editor picked up some formatting changes in addition. |
lalitb
left a comment
There was a problem hiding this comment.
LGTM with nit change. Thanks for the PR.
|
closing to open a separate PR |
Fixes #1763
Design discussion issue (if applicable) #
Changes
Use string value for event attribute
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes