Flatten field + fix u64 to string serde#1911
Merged
cijothomas merged 5 commits intoopen-telemetry:mainfrom Jul 16, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1911 +/- ##
=====================================
Coverage 74.9% 74.9%
=====================================
Files 122 122
Lines 20311 20311
=====================================
Hits 15217 15217
Misses 5094 5094 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Any thoughts here? |
Member
|
Thanks for the PR @hwrdtm . Will review it tomorrow. |
TommyCpp
reviewed
Jul 13, 2024
Member
|
@hwrdtm Thanks for the PR. The fix looks good, with nit comment as we are discussing. |
lalitb
approved these changes
Jul 16, 2024
bantonsson
pushed a commit
to bantonsson/opentelemetry-rust
that referenced
this pull request
Oct 9, 2025
Co-authored-by: Lalit Kumar Bhasin <labhas@microsoft.com> Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
takumi-earth
pushed a commit
to earthlings-dev/opentelemetry-rust
that referenced
this pull request
Jan 27, 2026
Co-authored-by: Lalit Kumar Bhasin <labhas@microsoft.com> Co-authored-by: Zhongyang Wu <zhongyang.wu@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR:
dataandvaluefields in order to be consistent with the JSON schema implemented on the OTEL Collectoru64andString./expected/metrics.jsonfile wouldn't even deserialize correctly.Testing
cargo test --workspace --all-features --test grpc_build -- --nocaptureto generate grpc files. Running the first time is expected to fail, as it will create the files.cargo test --workspace --all-features --test metrics 'test_serde' -- --nocaptureto run the new test case introduced in this PR.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changescc @lalitb