Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dedicated thread for Metrics PeriodicReader #2142

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
e5678e8
Use dedicated thread for metrics processing
cijothomas Sep 24, 2024
f2eff31
Merge branch 'main' into cijothomas/periodicreader
cijothomas Sep 24, 2024
91f7c2e
add comment on shutdown
cijothomas Sep 25, 2024
aedbd2c
pass timeout to exporters
cijothomas Oct 4, 2024
4198792
named thread and pass timeout to export
cijothomas Oct 4, 2024
966c9a6
test fixes
cijothomas Oct 4, 2024
8f71c7b
Add tests for periodic reader from various RT combinations (#2147)
cijothomas Sep 25, 2024
63728cc
Update doc comments (#2149)
utpilla Sep 25, 2024
c85ae55
Use weaver for semantic convention codegen (#2098)
lquerel Sep 26, 2024
d2c4ef5
Fix CI - Regenerate proto files, and selective msrv-patching (#2159)
lalitb Sep 30, 2024
6be205b
For Delta Temporarlity, avoid exporting when no new measurements are …
cijothomas Sep 30, 2024
7182be1
Improve internal opentelemetry logging - directly using tracing mcros…
lalitb Sep 30, 2024
5003dd3
MeterProvider modified to not do shutdown if user has already shut do…
cijothomas Sep 30, 2024
29ec004
Minor cleanups in Metrics module (#2155)
cijothomas Sep 30, 2024
ea2b9a7
Prepare 0.26.0 release, update Metrics API to Beta (#2160)
cijothomas Oct 1, 2024
ea0d788
Nit fixes to bug template (#2161)
cijothomas Oct 1, 2024
b96ab43
Metrics - Instrument Name Validation fixes (#2166)
cijothomas Oct 2, 2024
9eaba05
Improve internal opentelemetry logging (#2128)
lalitb Oct 4, 2024
e1e993d
Remove comments that are not relevant anymore (#2171)
cijothomas Oct 4, 2024
f17cde9
Docs: Remove unnecessary indentation for better readability (#2174)
moshensky Oct 4, 2024
10e2df8
Merge branch 'main' into cijothomas/periodicreader
cijothomas Oct 4, 2024
2b562b6
bring new change back
cijothomas Oct 4, 2024
020fb03
add internal logs liberally for now
cijothomas Oct 4, 2024
018cfde
fix otlp exporter for metric to not need rt
cijothomas Oct 4, 2024
a5b7de2
fix fmt
cijothomas Oct 4, 2024
58a3ba1
clenaups
cijothomas Oct 5, 2024
30b09a4
let more sleep for CI
cijothomas Oct 5, 2024
e51bca6
tests from tokio rt
cijothomas Oct 5, 2024
bc2aea2
test refactor
cijothomas Oct 5, 2024
218d9bb
make sync
cijothomas Oct 5, 2024
b78a3f3
small fix
cijothomas Oct 5, 2024
76899f2
fix stdout
cijothomas Oct 5, 2024
9e3be6a
inmeory
cijothomas Oct 5, 2024
ec4384d
continue on error for ci
cijothomas Oct 5, 2024
1e98f8c
remove sync
cijothomas Oct 5, 2024
75b4006
reomve ynsc
cijothomas Oct 5, 2024
84fb885
use mutex for messag
cijothomas Oct 6, 2024
3a12310
test for exporter failures
cijothomas Oct 7, 2024
b231d19
Merge branch 'main' into cijothomas/periodicreader
cijothomas Oct 7, 2024
6cc1428
fix clippy
cijothomas Oct 7, 2024
75fecfe
add async callbacks test
cijothomas Oct 7, 2024
883b337
fix clippy
cijothomas Oct 7, 2024
5a5eea4
reveiw comment
cijothomas Oct 7, 2024
9181b09
Merge branch 'main' into cijothomas/periodicreader
cijothomas Oct 7, 2024
fb26138
log interval in milliseconds
cijothomas Oct 7, 2024
f8b6c74
Merge branch 'main' into cijothomas/periodicreader
cijothomas Oct 7, 2024
c3f6931
Merge branch 'main' into cijothomas/periodicreader
cijothomas Oct 8, 2024
e0d7126
Merge branch 'main' into cijothomas/periodicreader
cijothomas Oct 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/metrics-basic/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ fn init_meter_provider() -> opentelemetry_sdk::metrics::SdkMeterProvider {
// .with_encoder(|writer, data|
// Ok(serde_json::to_writer_pretty(writer, &data).unwrap()))
.build();
let reader = PeriodicReader::builder(exporter, runtime::Tokio).build();
let reader = PeriodicReader::builder(exporter).build();
let provider = SdkMeterProvider::builder()
.with_reader(reader)
.with_resource(Resource::new([KeyValue::new(
Expand Down
Loading
Loading