Add tests for periodic reader from various RT combinations #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
reviewed
Sep 25, 2024
| { | ||
| let interval = std::time::Duration::from_millis(1); | ||
| let exporter = InMemoryMetricsExporter::default(); | ||
| let reader = PeriodicReader::builder(exporter.clone(), runtime) |
There was a problem hiding this comment.
I am using these tests to primarily validate that when 2142 approach is merged, we'll not have hangs/deadlocks, not matter which async runtime user is on.
(Ofcourse, will modify these tests to match 2142 later, as there will be no need of specifying runtime, and reducing test matrix too)
There was a problem hiding this comment.
Not as inconvenient but I guess the simpler thing (for review) would be to have the tests added in #2142 itself. Otherwise, we just increase the amount of diff for review.
utpilla
approved these changes
Sep 25, 2024
hdost
approved these changes
Sep 25, 2024
cijothomas
added a commit
to cijothomas/opentelemetry-rust
that referenced
this pull request
Oct 4, 2024
…metry#2147) These tests should help with testing open-telemetry#2142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests, ignoring the one that would fail.