Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make LogRecord fields private and add getters for encapsulation #2314

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+94 −52

Merge branch 'main' into logrecord-getters

4507e16
Select commit
Loading
Failed to load commit list.
Open

Make LogRecord fields private and add getters for encapsulation #2314

Merge branch 'main' into logrecord-getters
4507e16
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 21, 2024 in 1s

79.5% (+0.0%) compared to 465fcc2

View this Pull Request on Codecov

79.5% (+0.0%) compared to 465fcc2

Details

Codecov Report

Attention: Patch coverage is 85.24590% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (465fcc2) to head (4507e16).

Files with missing lines Patch % Lines
opentelemetry-stdout/src/logs/exporter.rs 0.0% 8 Missing ⚠️
opentelemetry-proto/src/transform/logs.rs 92.3% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #2314   +/-   ##
=====================================
  Coverage   79.5%   79.5%           
=====================================
  Files        123     123           
  Lines      21258   21275   +17     
=====================================
+ Hits       16905   16924   +19     
+ Misses      4353    4351    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

View more details on Codecov