Merge pull request #4 from martinkuba/feat/page_view_event_instrument…

…ation small fixes
open-telemetry · Oct 2, 2023 · 5a44ca8 · 5a44ca8
2 parents e09387b + 7e53674
commit 5a44ca8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/pkgs/instrumentations/web/page-view/README.md b/pkgs/instrumentations/web/page-view/README.md
@@ -24,7 +24,7 @@ import {
 import {
     EventEmitterProvider
 } from '@opentelemetry/sandbox-sdk-events';
-import { PageViewInstrumentation } from '@opentelemetry/sandbox-instrumentation-page-view';
+import { PageViewEventInstrumentation } from '@opentelemetry/sandbox-instrumentation-page-view';
 import { registerInstrumentations } from '@opentelemetry/sandbox-instrumentation';
 import { logs } from '@opentelemetry/sandbox-api-logs';
 import { events } from '@opentelemetry/sandbox-api-events';
@@ -38,7 +38,7 @@ const eventEmitterProvider = new EventEmitterProvider();
 events.setGlobalEventEmitterProvider(eventEmitterProvider);
 
 registerInstrumentations({
-  instrumentations: [new PageViewInstrumentation()],
+  instrumentations: [new PageViewEventInstrumentation()],
 });
 ```
 

diff --git a/pkgs/instrumentations/web/page-view/src/instrumentation.ts b/pkgs/instrumentations/web/page-view/src/instrumentation.ts
@@ -50,7 +50,7 @@ export class PageViewEventInstrumentation extends InstrumentationBase<unknown> {
       'browser',
       VERSION
     );
-    this.applyCustomEventData = config.applyCustomEventData;
+    this.applyCustomEventData = config?.applyCustomEventData;
   }
 
   init() {}

diff --git a/pkgs/instrumentations/web/page-view/src/version.ts b/pkgs/instrumentations/web/page-view/src/version.ts
@@ -15,4 +15,4 @@
  */
 
 // this is autogenerated file for @opentelemetry/sandbox-instrumentation-page-view, see scripts/version-update.js
-export const VERSION = '0.38.0';
+export const VERSION = '0.43.0';
diff --git a/pkgs/instrumentations/web/page-view/test/pageView.test.ts b/pkgs/instrumentations/web/page-view/test/pageView.test.ts
@@ -29,7 +29,6 @@ import { logs } from '@opentelemetry/sandbox-api-logs';
 import { events } from '@opentelemetry/sandbox-api-events';
 import { PageTypes } from '../src/enums/PageTypes';
 
-
 describe('PageView Instrumentation', () => {
   let plugin: PageViewEventInstrumentation;
   const sandbox = sinon.createSandbox();