Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add page view event instrumentation #112

Conversation

Abinet18
Copy link
Contributor

Issue #81

This instrumentation uses the logs api to create events when a page is viewed, or when a soft navigation results in route change (virtual page view).

@Abinet18 Abinet18 changed the base branch from main to auto-instrumentation-poc May 15, 2023 16:46
@Abinet18 Abinet18 marked this pull request as draft May 15, 2023 16:46
@Abinet18
Copy link
Contributor Author

@martinkuba , assign this to me

@Abinet18 Abinet18 changed the title [WIP] feat: Add page view event instrumentation feat: Add page view event instrumentation May 17, 2023
@Abinet18 Abinet18 marked this pull request as ready for review May 17, 2023 21:23
@Abinet18
Copy link
Contributor Author

@martinkuba , this is ready for review. Can you add reviewers to it.

pkgs/api-logs/src/types/LogRecord.ts Outdated Show resolved Hide resolved
pkgs/api-logs/src/types/LoggerOptions.ts Outdated Show resolved Hide resolved
pkgs/instrumentations/web/page-view/src/instrumentation.ts Outdated Show resolved Hide resolved
pkgs/instrumentations/web/page-view/src/instrumentation.ts Outdated Show resolved Hide resolved
pkgs/instrumentations/web/page-view/src/types.ts Outdated Show resolved Hide resolved
pkgs/instrumentations/web/page-view/src/instrumentation.ts Outdated Show resolved Hide resolved
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 21, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@Abinet18 Abinet18 force-pushed the feat/page_view_event_instrumentation branch from 1c824ea to ed6ab93 Compare June 21, 2023 23:54
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@Abinet18 Abinet18 force-pushed the feat/page_view_event_instrumentation branch from ed6ab93 to ffb53ba Compare June 23, 2023 17:54
@martinkuba
Copy link
Collaborator

@Abinet18 Thanks for making the changes to get the emitter from the API. We also need to remove all the sdk dependencies from package.json, and also please add a basic readme.

@Abinet18
Copy link
Contributor Author

We also need to remove all the sdk dependencies from package.json, and also please add a basic readme.

Added the readme. The sdk dependencies are still used in the test

@Abinet18 Abinet18 force-pushed the feat/page_view_event_instrumentation branch from cc6483f to 12b84c6 Compare September 13, 2023 16:30
@Abinet18 Abinet18 force-pushed the feat/page_view_event_instrumentation branch from 78e38c1 to ae18bda Compare September 27, 2023 22:14
@martinkuba martinkuba merged commit c90dcb3 into open-telemetry:auto-instrumentation-poc Oct 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants