Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update POC branch with latest from main #191

Conversation

martinkuba
Copy link
Collaborator

No description provided.

Nico385412 and others added 30 commits June 21, 2023 14:16
* chore: extract sql commenting logic to common package

* feat(instrumentation-mysql2): sqlcommenter support

* fix(instrumentation-mysql2): properly assign commented sql

* chore(instrumentation-mysql2): test sqlcommenter

* chore(instrumentation-mysql2): update readme with new option

* chore: revert workflows autoformat

* chore(sql-common): specify api devDep

* chore: update release-please manifests

* chore(sql-common): fix copy pasted readme

* fix(instrumentation-mysql2): proper test cleanup logic

* fix(instrumentation-mysql2): proper test config handling

---------

Co-authored-by: Haddas Bronfman <[email protected]>
…(#3951)

* fix(example-opencensus-shim): avoid opencensus instrumentations being auto imported

* chore: changelog

---------

Co-authored-by: Haddas Bronfman <[email protected]>
chore: fix typo in test description

Noticed ECS on Fargate is missing some cloud resource attributes.
Comparing similar implementations like the Go ECS detector (https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/5fff1040a2844d4d435359b8108202317762593d/processor/resourcedetectionprocessor/internal/aws/ecs/ecs.go#L69);
they determine these missing values based on the metadata. This implements them in a similar fashion.

Co-authored-by: Haddas Bronfman <[email protected]>
… DynamoDB attributes (#1524)

* feat(opentelemetry-instrumentation-aws-sdk): add missing spec-defined DynamoDB attributes

* feat(opentelemetry-instrumentation-aws-sdk): add checks for input attributes and additional unit tests

* feat(opentelemetry-instrumentation-aws-sdk): run lint on dynamoDB unit tests

---------

Co-authored-by: Haddas Bronfman <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
…ormance resource timing object for custom attributes (#1529)

* feat(opentelemetry-instrumentation-document-load): Add access to performance resource timing object for custom attributes

* update docs

* fix lint

* Apply suggestions from code review

Co-authored-by: Marc Pichler <[email protected]>

---------

Co-authored-by: Marc Pichler <[email protected]>
…ment variable (#1227)

* feat(lambda): add OTEL_LAMBDA_DISABLE_AWS_CONTEXT_PROPAGATION environment option

* Lint

* feat: copy object to prevent modification

* test: add coverage

* chore: lint

* Fix build

---------

Co-authored-by: Gerhard Stöbich <[email protected]>
* feat(mongodb): add support for v5

* refactor(mongodb): avoid duplicating code for v4 & v5

* fix: lint

* refactor(mongodb): use range for mongodb version check

* chore(mongodb): make test commands consistent

* refactor(mongodb): adapt code based on main's changes

* chore: revert mongodb bump in devDependencies

* refactor: adapt code based on comments

* chore: re-use old order for tests suites

* refactor: simply metrics tests

* test: fix DB name in v5 tests

* chore: revert MongoDB to 3.6.11 in package.json

* test: fix compilation issue due to different signatures (v3 vs v5)

* fix: lint

---------

Co-authored-by: Haddas Bronfman <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
* docs: document merge reqiurements

* docs: remove redundant wording

* docs: remove redundant wording

* docs: lint
Vunovati and others added 21 commits September 12, 2023 16:46
…metry-js@5615b1c)

  - commit 5615b1c
  - Author: Vadim Korolik <[email protected]>
  - Date:   Wed Sep 13 00:12:20 2023 -0700
  -     fix(sdk-node): move @opentelemetry/exporter-jaeger to dev dependencies (#4049)
  - ...
### Auto resolving 17 conflicts to select the master repo version
Summary of changes by file state
UA (Updated <=> Added): 9
AU (Added <=> Updated): 4
DD (Deleted <=> Deleted): 4

 - (UA) auto-merge/js/experimental/packages/exporter-logs-otlp-proto/src/platform/browser/OTLPLogExporter.ts - Unmerged, added by them => checkout theirs
 - (AU) auto-merge/js/experimental/packages/exporter-logs-otlp-proto/src/platform/browser/OTLPLogsExporter.ts - Added in ours => checkout ours
 - (UA) auto-merge/js/experimental/packages/exporter-logs-otlp-proto/src/platform/node/OTLPLogExporter.ts - Unmerged, added by them => checkout theirs
 - (AU) auto-merge/js/experimental/packages/exporter-logs-otlp-proto/src/platform/node/OTLPLogsExporter.ts - Added in ours => checkout ours
 - (UA) auto-merge/js/experimental/packages/exporter-logs-otlp-proto/test/browser/OTLPLogExporter.test.ts - Unmerged, added by them => checkout theirs
 - (AU) auto-merge/js/experimental/packages/exporter-logs-otlp-proto/test/browser/OTLPLogsExporter.test.ts - Added in ours => checkout ours
 - (UA) auto-merge/js/experimental/packages/exporter-logs-otlp-proto/test/node/OTLPLogExporter.test.ts - Unmerged, added by them => checkout theirs
 - (AU) auto-merge/js/experimental/packages/exporter-logs-otlp-proto/test/node/OTLPLogsExporter.test.ts - Added in ours => checkout ours
 - (UA) auto-merge/js/packages/opentelemetry-exporter-jaeger/src/version.js - Unmerged, added by them => checkout theirs
 - (UA) auto-merge/js/packages/opentelemetry-exporter-zipkin/src/version.js - Unmerged, added by them => checkout theirs
 - (UA) auto-merge/js/packages/opentelemetry-propagator-b3/src/version.js - Unmerged, added by them => checkout theirs
 - (UA) auto-merge/js/packages/opentelemetry-propagator-jaeger/src/version.js - Unmerged, added by them => checkout theirs
 - (UA) auto-merge/js/packages/sdk-metrics/src/version.js - Unmerged, added by them => checkout theirs
 - (DD) experimental/packages/exporter-logs-otlp-proto/src/platform/browser/OTLPLogsExporter.ts - Removed from both
 - (DD) experimental/packages/exporter-logs-otlp-proto/src/platform/node/OTLPLogsExporter.ts - Removed from both
...truncated...
…opentelemetry-js-contrib@b10224b)

  - commit b10224b
  - Author: Mend Renovate <[email protected]>
  - Date:   Mon Sep 11 13:54:55 2023 +0200
  -     chore(deps): update all patch versions (#1675)
  - ...
Processing otel-js
 - (xS) /auto-merge/js/.github/workflows/codeql-analysis.yml - Re-Copying master file as size mismatch 1115 !== 558
 - (*E) /auto-merge/js/experimental/packages/exporter-logs-otlp-proto/src/platform/browser/OTLPLogsExporter.ts - Removing extra file
 - (*E) /auto-merge/js/experimental/packages/exporter-logs-otlp-proto/src/platform/node/OTLPLogsExporter.ts - Removing extra file
 - (*E) /auto-merge/js/experimental/packages/exporter-logs-otlp-proto/test/browser/OTLPLogsExporter.test.ts - Removing extra file
 - (*E) /auto-merge/js/experimental/packages/exporter-logs-otlp-proto/test/node/OTLPLogsExporter.test.ts - Removing extra file
 - (xM) /auto-merge/js/packages/template/src/version.js - Re-Copying master file
 - (*F) /packages - Removing extra folder packages
Processing otel-js-contrib
 - (xS) /auto-merge/contrib/.github/workflows/codeql-analysis.yml - Re-Copying master file as size mismatch 558 !== 1115
…etrybot/auto-merge-repo-staging

[AutoMerge][Staging] Merging change(s) from otel-js; otel-js-contrib;
…metry-js@be16272)

  - commit be16272
  - Author: Marc Pichler <[email protected]>
  - Date:   Mon Sep 18 17:30:52 2023 +0200
  -     feat(exporter-metrics-otlp-proto): add esm build (#4099)
  - ...
### Auto resolving 12 conflicts to select the master repo version
Summary of changes by file state
UA (Updated <=> Added): 8
AU (Added <=> Updated): 2
DD (Deleted <=> Deleted): 2

 - (UA) auto-merge/js/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/tsconfig.esm.json - Unmerged, added by them => checkout theirs
 - (UA) auto-merge/js/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/tsconfig.esnext.json - Unmerged, added by them => checkout theirs
 - (UA) auto-merge/js/experimental/packages/shim-opencensus/src/OpenCensusMetricProducer.ts - Unmerged, added by them => checkout theirs
 - (UA) auto-merge/js/experimental/packages/shim-opencensus/src/metric-transform.ts - Unmerged, added by them => checkout theirs
 - (UA) auto-merge/js/experimental/packages/shim-opencensus/src/trace-transform.ts - Unmerged, added by them => checkout theirs
 - (AU) auto-merge/js/experimental/packages/shim-opencensus/src/transform.ts - Added in ours => checkout ours
 - (UA) auto-merge/js/experimental/packages/shim-opencensus/test/OpenCensusMetricProducer.test.ts - Unmerged, added by them => checkout theirs
 - (UA) auto-merge/js/experimental/packages/shim-opencensus/test/metric-transform.test.ts - Unmerged, added by them => checkout theirs
 - (UA) auto-merge/js/experimental/packages/shim-opencensus/test/trace-transform.test.ts - Unmerged, added by them => checkout theirs
 - (AU) auto-merge/js/experimental/packages/shim-opencensus/test/transform.test.ts - Added in ours => checkout ours
 - (DD) experimental/packages/shim-opencensus/src/transform.ts - Removed from both
 - (DD) experimental/packages/shim-opencensus/test/transform.test.ts - Removed from both
…opentelemetry-js-contrib@deb9aa4)

  - commit deb9aa4
  - Author: Mend Renovate <[email protected]>
  - Date:   Thu Sep 14 13:34:06 2023 +0200
  -     fix(deps): update otel core experimental to v0.43.0 (#1676)
  - ...
Processing otel-js
 - (*E) /auto-merge/js/experimental/packages/shim-opencensus/src/transform.ts - Removing extra file
 - (*E) /auto-merge/js/experimental/packages/shim-opencensus/test/transform.test.ts - Removing extra file
Processing otel-js-contrib
…etrybot/auto-merge-repo-staging

[AutoMerge][Staging] Merging change(s) from otel-js; otel-js-contrib;
### Moving package from auto-merge/js/api to pkgs/api/
### Moving package from auto-merge/js/packages/opentelemetry-semantic-conventions/ to pkgs/semantic-conventions/
### Moving package from auto-merge/js/packages/opentelemetry-core/ to pkgs/core/
### Moving package from auto-merge/js/packages/opentelemetry-resources/ to pkgs/resources/
### Moving package from auto-merge/js/packages/opentelemetry-context-zone-peer-dep/ to pkgs/context/zone-peer-dep/
### Moving package from auto-merge/js/packages/opentelemetry-context-zone/ to pkgs/context/zone/
### Moving package from auto-merge/js/packages/opentelemetry-propagator-b3/ to pkgs/propagators/b3/
### Moving package from auto-merge/js/packages/opentelemetry-sdk-trace-base/ to pkgs/sdk/trace/base/
### Moving package from auto-merge/js/packages/opentelemetry-sdk-trace-web/ to pkgs/sdk/trace/web/
### Moving package from auto-merge/js/packages/sdk-metrics/ to pkgs/sdk/metrics/
### Moving package from auto-merge/js/experimental/packages/sdk-logs/ to pkgs/sdk/logs/
### Moving package from auto-merge/js/experimental/packages/otlp-exporter-base to pkgs/exporters/otlp/base/
### Moving package from auto-merge/js/experimental/packages/otlp-transformer to pkgs/exporters/otlp/transformer
### Moving package from auto-merge/js/experimental/packages/otlp-proto-exporter-base to pkgs/exporters/otlp/proto-base
### Moving package from auto-merge/js/packages/opentelemetry-exporter-zipkin/ to pkgs/exporters/zipkin/
### Moving package from auto-merge/js/experimental/packages/exporter-trace-otlp-proto to pkgs/exporters/otlp/trace/proto/
### Moving package from auto-merge/js/experimental/packages/exporter-trace-otlp-http to pkgs/exporters/otlp/trace/http/
### Moving package from auto-merge/js/experimental/packages/opentelemetry-exporter-metrics-otlp-http to pkgs/exporters/otlp/metrics/http/
### Moving package from auto-merge/js/experimental/packages/exporter-logs-otlp-proto to pkgs/exporters/otlp/logs/proto/
### Moving package from auto-merge/js/experimental/packages/exporter-logs-otlp-http to pkgs/exporters/otlp/logs/http/
### Moving package from auto-merge/js/experimental/packages/opentelemetry-instrumentation/ to pkgs/instrumentations/instrumentation/
### Moving package from auto-merge/js/experimental/packages/opentelemetry-instrumentation-fetch/ to pkgs/instrumentations/web/fetch
### Moving package from auto-merge/js/experimental/packages/opentelemetry-instrumentation-xml-http-request/ to pkgs/instrumentations/web/xhr
### Moving package from auto-merge/contrib/plugins/web/opentelemetry-instrumentation-document-load/ to pkgs/instrumentations/web/document-load/
### Moving package from auto-merge/contrib/plugins/web/opentelemetry-instrumentation-user-interaction/ to pkgs/instrumentations/web/user-interaction/
### Moving package from auto-merge/contrib/plugins/web/opentelemetry-instrumentation-long-task/ to pkgs/instrumentations/web/long-task/
### Moving package from auto-merge/contrib/metapackages/auto-instrumentations-web/ to pkgs/instrumentations/web/auto/
### Moving package from auto-merge/js/experimental/packages/opentelemetry-browser-detector/ to pkgs/detectors/browser/
### Moving package from auto-merge/js/experimental/packages/api-logs/ to pkgs/api-logs/
### Moving package from auto-merge/js/experimental/packages/api-events/ to pkgs/api-events/
### Moving package from auto-merge/js/examples/opentelemetry-web/ to examples/web/js/
### Auto resolving 17 conflicts to select the master repo version
Summary of changes by file state
DD (Deleted <=> Deleted): 4
DU (Deleted <=> Updated): 2
AA (Added <=> Added): 3
UA (Updated <=> Added): 4
AU (Added <=> Updated): 4

 - (DD) auto-merge/js/experimental/packages/exporter-logs-otlp-proto/src/platform/browser/OTLPLogsExporter.ts - Removed from both
 - (DD) auto-merge/js/experimental/packages/exporter-logs-otlp-proto/src/platform/node/OTLPLogsExporter.ts - Removed from both
 - (DD) auto-merge/js/experimental/packages/exporter-logs-otlp-proto/test/browser/OTLPLogsExporter.test.ts - Removed from both
 - (DD) auto-merge/js/experimental/packages/exporter-logs-otlp-proto/test/node/OTLPLogsExporter.test.ts - Removed from both
 - (DU) auto-merge/js/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/tsconfig.esm.json - Deleted by us => checkout theirs
 - (DU) auto-merge/js/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/tsconfig.esnext.json - Deleted by us => checkout theirs
 - (AA) pkgs/exporters/otlp/logs/http/package.json - Added in both => checkout theirs
 - (UA) pkgs/exporters/otlp/logs/proto/src/platform/browser/OTLPLogExporter.ts - Unmerged, added by them => checkout theirs
 - (AU) pkgs/exporters/otlp/logs/proto/src/platform/browser/OTLPLogsExporter.ts - Added in ours => checkout ours
 - (UA) pkgs/exporters/otlp/logs/proto/src/platform/node/OTLPLogExporter.ts - Unmerged, added by them => checkout theirs
 - (AU) pkgs/exporters/otlp/logs/proto/src/platform/node/OTLPLogsExporter.ts - Added in ours => checkout ours
 - (UA) pkgs/exporters/otlp/logs/proto/test/browser/OTLPLogExporter.test.ts - Unmerged, added by them => checkout theirs
 - (AU) pkgs/exporters/otlp/logs/proto/test/browser/OTLPLogsExporter.test.ts - Added in ours => checkout ours
 - (UA) pkgs/exporters/otlp/logs/proto/test/node/OTLPLogExporter.test.ts - Unmerged, added by them => checkout theirs
 - (AU) pkgs/exporters/otlp/logs/proto/test/node/OTLPLogsExporter.test.ts - Added in ours => checkout ours
 - (AA) pkgs/exporters/otlp/metrics/http/package.json - Added in both => checkout theirs
 - (AA) pkgs/exporters/otlp/proto-base/protos - Added in both => checkout theirs
Identifying and fixing merge issues from staged repos
...truncated...
…etrybot/merge-main

[AutoMerge][Main] Merging staged change(s) to main
@martinkuba martinkuba marked this pull request as draft September 20, 2023 19:11
@martinkuba martinkuba marked this pull request as ready for review September 20, 2023 19:34
@martinkuba
Copy link
Collaborator Author

This does not look right to me (and tests are failing). I must have done something incorrectly. I might close this and open a new PR...

@martinkuba martinkuba closed this Sep 20, 2023
@martinkuba martinkuba deleted the auto-instrumentation-poc branch September 20, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.