Define "none" numeric value

[Kielek]

Fixes N/A

Changes

Define "none" numeric value.

It will be useful to correctly set OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT to no limit. For now, it should use int.maxvalue or similar values.

Related issues for enum handling #2102

[pellared]

👍

PS. Feels very "Pythonish" 😉

[Oberon00]

First, I don't think this is specific to numeric values. Booleans, strings, enums, etc., might accept "null" values just as well.
Second, there is no concept of "null value" in this environment specification, so this specification, as written now, has no meaning (or an unclear meaning).
Your goal seems to allow explicitly setting "no limit" in the limit configuration. You should add a more specific spec to that subsection, instead of the generic section here.

(PS: Congrats on creating PR #3000 🥳)

[reyang]

It will be useful to correctly set OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT to no limit. For now, it should use int.maxvalue or similar values.

Why would someone want "no limit"? Related to #2960 (comment).

[reyang]

Need to understand why "no limit" is needed.

[pellared]

Need to understand why "no limit" is needed.

I agree that "unbounded limits" is a bad practice from "reliability" standpoint. But I do not see anything in the spec that disallows limitless configurations. Current default for OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT and OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT is "no limit". Wouldn't changing it be a breaking change?

Related comment: #2045 (comment)

If it is possible to have a unlimited configuration then we should allow setting it.

I have no clear nor strong opinion 😆

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[Kielek]

I am closing this issue per last .NET AutoInstrumentation Discussion with @carlosalberto.
For now, there will be no possibility to set no-limit options. It is considered as to unpredictable.

Instead we should consider to change default values for OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT and OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT . I do not think that is is good practice to have default value which cannot be set by appropriate env. value.