Skip to content

An alternative explanation of cardinality #3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reyang wants to merge 3 commits into from
Closed

An alternative explanation of cardinality #3883

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6554b6d
an alternative explanation of cardinality
reyang Feb 15, 2024
cc488d8
Update specification/metrics/sdk.md
reyang Feb 16, 2024
a9456a5
Update specification/metrics/sdk.md
reyang Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,10 +731,10 @@ of metrics across successive collections.

**Status**: [Experimental](../document-status.md)

SDKs SHOULD support being configured with a cardinality limit. The number of
unique combinations of attributes is called cardinality. For a given metric, the
cardinality limit is a hard limit on the number of metric points that can be
collected during a collection cycle.
SDKs SHOULD support configurable cardinality limits. The number of
unique attribute sets passed by a user is called cardinality. For a given
Copy link
Copy Markdown
Member

@trask trask Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"passed by a user" seems to imply before any metric attribute filters are applied? (e.g. https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#instrument-advisory-parameter-attributes)

Copy link
Copy Markdown
Member

@pellared pellared Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that reopening and solving #3803 could be helpful.

metric, the cardinality limit is a hard limit on the number of metric points
that can be collected during a collection cycle.

#### Configuration

Expand Down