Refactor description of span kind #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
force-pushed
the
refactor-span-kind-another-try
branch
from
5fae164
to
f81dfad
Compare
drewby
reviewed
Aug 7, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
lmolkova
force-pushed
the
refactor-span-kind-another-try
branch
from
f81dfad
to
152e677
Compare
jsuereth
approved these changes
Aug 20, 2024
trask
reviewed
Aug 20, 2024
yurishkuro
reviewed
Aug 20, 2024
yurishkuro
reviewed
Aug 20, 2024
yurishkuro
reviewed
Aug 20, 2024
yurishkuro
reviewed
Aug 20, 2024
yurishkuro
reviewed
Aug 20, 2024
yurishkuro
reviewed
Aug 20, 2024
Co-authored-by: Tigran Najaryan <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
yurishkuro
approved these changes
Aug 26, 2024
jmacd
approved these changes
Aug 26, 2024
trask
approved these changes
Aug 26, 2024
Co-authored-by: Trask Stalnaker <[email protected]>
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
joaopgrassi
approved these changes
Sep 3, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Fixes open-telemetry#3172 (Built on top of open-telemetry#4088) ## Changes - Explains kinds without assuming presence of parent/children - Adds links as another correlation mechanism - Normalizes nested client spans even further - database, messaging, RPC, and LLM semantic conventions require CLIENT kind for logical client operation. - Does not touch INTERNAL kind yet - open-telemetry#4179 * [x] Related issues open-telemetry#3172, open-telemetry/semantic-conventions#674, open-telemetry/oteps#172, open-telemetry/semantic-conventions#1315 * ~~[ ] Related [OTEP(s)](https://github.com/open-telemetry/oteps) #~~ * ~~[ ] Links to the prototypes (when adding or changing features)~~ * [x] [`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md) file updated for non-trivial changes * ~~[ ] [`spec-compliance-matrix.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md) updated if necessary~~ --------- Co-authored-by: Tigran Najaryan <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3172
(Built on top of #4088)
Changes
INTERNALGenAI/db spans instead of requiring the kind to beCLIENTsemantic-conventions#1315[ ] Related OTEP(s) #[ ] Links to the prototypes (when adding or changing features)CHANGELOG.mdfile updated for non-trivial changes[ ]spec-compliance-matrix.mdupdated if necessary