Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEP: Logger.Enabled #4290

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
b78c2b3
otep boilerplate
pellared Nov 12, 2024
dad7d90
Update file name
pellared Nov 12, 2024
8d194d6
Update 4290-logger-enabled.md
pellared Dec 10, 2024
e90776f
Update 4290-logger-enabled.md
pellared Dec 10, 2024
44c26df
Update 4290-logger-enabled.md
pellared Dec 10, 2024
0dfdb46
Update 4290-logger-enabled.md
pellared Dec 10, 2024
28c7ca4
Update 4290-logger-enabled.md
pellared Dec 10, 2024
5707a91
Update 4290-logger-enabled.md
pellared Dec 10, 2024
f26dfaa
Update 4290-logger-enabled.md
pellared Dec 10, 2024
26f915c
Update oteps/logs/4290-logger-enabled.md
pellared Dec 10, 2024
ba900ee
Update oteps/logs/4290-logger-enabled.md
pellared Dec 10, 2024
84a2779
Update oteps/logs/4290-logger-enabled.md
pellared Dec 10, 2024
d092b72
Update 4290-logger-enabled.md
pellared Dec 11, 2024
a5aee99
Update 4290-logger-enabled.md
pellared Dec 11, 2024
45b6c90
Apply suggestions from code review
pellared Dec 11, 2024
d258965
Apply suggestions from code review
pellared Dec 11, 2024
cf05e57
Update 4290-logger-enabled.md
pellared Dec 11, 2024
4e60d96
Update 4290-logger-enabled.md
pellared Dec 16, 2024
8096622
Update 4290-logger-enabled.md
pellared Dec 16, 2024
21b1702
Update 4290-logger-enabled.md
pellared Dec 16, 2024
36bcf8d
Update 4290-logger-enabled.md
pellared Dec 16, 2024
fa7ad76
Update 4290-logger-enabled.md
pellared Dec 16, 2024
18424ce
Update 4290-logger-enabled.md
pellared Dec 16, 2024
2bf0540
Update 4290-logger-enabled.md
pellared Dec 16, 2024
e907d2e
Update 4290-logger-enabled.md
pellared Dec 16, 2024
9cd2311
Update 4290-logger-enabled.md
pellared Dec 16, 2024
9f3ed05
Update 4290-logger-enabled.md
pellared Dec 16, 2024
e108b90
Update 4290-logger-enabled.md
pellared Dec 16, 2024
b782c8f
Update 4290-logger-enabled.md
pellared Dec 16, 2024
1bc5bb4
Update 4290-logger-enabled.md
pellared Dec 16, 2024
ce6d2a6
Update 4290-logger-enabled.md
pellared Dec 16, 2024
6978351
Update 4290-logger-enabled.md
pellared Dec 16, 2024
6d25690
Update 4290-logger-enabled.md
pellared Dec 16, 2024
b963292
Update 4290-logger-enabled.md
pellared Dec 16, 2024
e1e727b
Update CHANGELOG.md
pellared Dec 16, 2024
aee7348
Update 4290-logger-enabled.md
pellared Dec 16, 2024
93860bf
Update 4290-logger-enabled.md
pellared Dec 16, 2024
e4cd587
Update 4290-logger-enabled.md
pellared Dec 16, 2024
ebab731
Update 4290-logger-enabled.md
pellared Dec 16, 2024
8b98332
Update 4290-logger-enabled.md
pellared Dec 16, 2024
2bbdab7
Update 4290-logger-enabled.md
pellared Dec 16, 2024
472d151
Update 4290-logger-enabled.md
pellared Dec 16, 2024
96fbf43
Update 4290-logger-enabled.md
pellared Dec 17, 2024
4ee1696
Update 4290-logger-enabled.md
pellared Dec 18, 2024
a6a87a9
Update 4290-logger-enabled.md
pellared Dec 18, 2024
509c501
Update 4290-logger-enabled.md
pellared Dec 18, 2024
222425d
Update 4290-logger-enabled.md
pellared Jan 8, 2025
0e6c0ae
Move LoggerConfig.trace_based to Future possibilities
pellared Jan 9, 2025
07cf515
minimum_severity_level and MinimumSeverityLevelProcessor
pellared Jan 9, 2025
0c555f9
Refine Dynamic Evaluation in LoggerConfig and move to Future possibil…
pellared Jan 9, 2025
48c1e11
Refine Dynamic Evaluation in LoggerConfig
pellared Jan 9, 2025
9431fac
Merge branch 'main' into otep-log-enabled
pellared Jan 9, 2025
be8343e
Merge branch 'main' into otep-log-enabled
pellared Jan 14, 2025
1a5761e
Merge branch 'main' into otep-log-enabled
pellared Jan 15, 2025
c5c8f3b
Apply suggestions from code review
pellared Jan 15, 2025
76d59e3
Update 4290-logger-enabled.md
pellared Jan 15, 2025
257fbf3
Update 4290-logger-enabled.md
pellared Jan 15, 2025
ccc1b92
Merge branch 'main' into otep-log-enabled
pellared Jan 15, 2025
bb36dd3
Update 4290-logger-enabled.md
pellared Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refine Dynamic Evaluation in LoggerConfig
  • Loading branch information
pellared committed Jan 9, 2025
commit 48c1e110fec85e2ca1793117141e960d40a52e36
9 changes: 5 additions & 4 deletions oteps/logs/4290-logger-enabled.md
Original file line number Diff line number Diff line change
@@ -237,14 +237,15 @@ There is a [proposal](https://github.com/open-telemetry/opentelemetry-specificat
suggested dynamic evaluation in `LoggerConfig` instead of static configuration
to make the `LoggerConfig` to support dynamic evaluation.

However, since the purpose of `LoggerConfig` is static configuration,
and use cases (5) and (6) are tied to log record processing,
extending `LogRecordProcessor` seem more appropriate.

Additionally, nothing prevents adding some other way of configuring Loggers similar to
[Metrics View](../../specification/metrics/sdk.md#view).
This was proposed [here](https://github.com/open-telemetry/opentelemetry-specification/pull/4290#discussion_r1908897211).

It is worth mentioning that the purpose of `LoggerConfig` is `Logger` configuration.
It won't solve use cases (5) and (6) that are tied to log processing pipelines.
This mechanism could not be used to setup different filters for each registered
processor.

### Extending Logger.Enabled

The `Enabled` API could be extended in the future
Loading