-
Notifications
You must be signed in to change notification settings - Fork 158
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Fix startTime of span. SpanBuilderSDK startTime was being initialised with current system time, this was forcing this value to be used as the startTime when the RecordEventsReadableSpan was initialised. This was causing two big issues: - The start time was set when the spanBuilder was created, not when the span was really started - If the user decided to use an external clock, it would only be used for the end time, not for the start time. Which would make the duration to be always wrong
- Loading branch information
Ignacio Bonafonte
authored
Nov 29, 2021
1 parent
d7eb282
commit cadbcbf
Showing
2 changed files
with
4 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters