-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mypy doc #1611
Add mypy doc #1611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline copyedit comments. Thanks!
Broader comment: As it stands the added page is very specific. Might it make sense to add the content to another page (such as the Python landing page), or to generalize the page title? Just a thought, I'm ok if this lands with the current page addition if others are ok with that too. |
I'd like to get the @open-telemetry/python-approvers take on this being a specific page. One way to look at mypy is that it's analogous to TypeScript, which is to say it's a dialect of the same core/family of language. And as it turns out, there are some unique things to keep in mind when using it. We have the same thing to consider for the JS docs long-term as well. |
This is absolutely necessary if you are using the This seems to be required only for the Without this option one gets errors like the following:
|
Co-authored-by: Patrice Chalin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@open-telemetry/python-approvers - any feedback on this? |
Looks good to me initially. Just a few things: Is the underlying intention of this documentation to explain how to use If the intent of running Regarding this comment, we actually should update the API to also dynamically generate the contents of |
@ocelotl The intention here is around end-user use of the SDK when instrumenting. I also had a coworker try out otel-python for themselves in a flask app and they ran into the same issue, needing to add this to their configuration to unblock themselves. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all!
This came up before, but there was some recent conversation here that made me feel like we could do a quick doc explaining how to configure a mypy project: open-telemetry/opentelemetry-python#2591 (comment)
There's mention of potentially needing this in a project configuration file:
I do not know if this is also necessary, but it should be easy to add if it is.