Skip to content

Point to Weaver main branch to include gix fix to not build openssl on windows platform and fix tag parsing issue causing crashes in latest weaver release bit.#2910

Open
sapatrjv wants to merge 4 commits intoopen-telemetry:mainfrom
sapatrjv:dev/sapatr/referweaverbrachtoavoidopensslbuild
Open

Point to Weaver main branch to include gix fix to not build openssl on windows platform and fix tag parsing issue causing crashes in latest weaver release bit.#2910
sapatrjv wants to merge 4 commits intoopen-telemetry:mainfrom
sapatrjv:dev/sapatr/referweaverbrachtoavoidopensslbuild

Conversation

@sapatrjv
Copy link
Copy Markdown
Contributor

@sapatrjv sapatrjv commented May 8, 2026

Change Summary

What issue does this PR close?

How are these changes tested?

Search cargo tree and check on windows platform no openssl dependency.
Ran Cargo xtast check

Are there any user-facing changes?

@sapatrjv sapatrjv requested a review from a team as a code owner May 8, 2026 19:32
@github-actions github-actions Bot added the rust Pull requests that update Rust code label May 8, 2026
weaver_resolved_schema = { git = "https://github.com/open-telemetry/weaver.git", tag = "v0.21.2"}
weaver_resolver = { git = "https://github.com/open-telemetry/weaver.git", tag = "v0.21.2"}
weaver_semconv = { git = "https://github.com/open-telemetry/weaver.git", tag = "v0.21.2"}
weaver_common = { git = "https://github.com/open-telemetry/weaver.git", rev = "37c645a5ebc9e0d2a68f9228205f1d7d6a32ccbc"}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we ask weaver for a release instead?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, it looks like there is a new release already, but then I am wondering why we use commit hash instead of tag?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested for the same but no response. It is almost 2 weeks no weaver release. Hence taking this approach. Once weaver release is done rev# will be replaced with tag#.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lquerel should be able to help with weaver release, if we badly need it soon

@lalitb
Copy link
Copy Markdown
Member

lalitb commented May 8, 2026

@sapatrjv - There are some changes in the new weaver version, for which CI is failing

Checking otap-df-admin v0.1.0 (/home/runner/work/otel-arrow/otel-arrow/rust/otap-dataflow/crates/admin)
    Checking otap-df-controller v0.1.0 (/home/runner/work/otel-arrow/otel-arrow/rust/otap-dataflow/crates/controller)
    Checking otap-df-core-nodes v0.1.0 (/home/runner/work/otel-arrow/otel-arrow/rust/otap-dataflow/crates/core-nodes)
    Checking otap-df-contrib-nodes v0.1.0 (/home/runner/work/otel-arrow/otel-arrow/rust/otap-dataflow/crates/contrib-nodes)
error[E0061]: this function takes 3 arguments but 2 arguments were supplied
    --> crates/core-nodes/src/receivers/host_metrics_receiver/procfs/tests.rs:1417:9
     |
1417 |         RegistryRepo::try_new("main", &registry_path).expect("semantic convention registry");
     |         ^^^^^^^^^^^^^^^^^^^^^------------------------ argument #3 of type `&mut std::vec::Vec<weaver_semconv::Error>` is missing
     |
note: expected `Option<SchemaUrl>`, found `&str`
    --> crates/core-nodes/src/receivers/host_metrics_receiver/procfs/tests.rs:1417:31
     |
1417 |         RegistryRepo::try_new("main", &registry_path).expect("semantic convention registry");
     |                               ^^^^^^
     = note:   expected enum `std::option::Option<weaver_semconv::schema_url::SchemaUrl>`
             found reference `&'static str`
note: associated function defined here
    --> /home/runner/.cargo/git/checkouts/weaver-718c120ef41f6c7b/37c645a/crates/weaver_semconv/src/registry_repo.rs:107:12
     |
 107 |     pub fn try_new(
     |            ^^^^^^^
help: provide the argument
     |
1417 -         RegistryRepo::try_new("main", &registry_path).expect("semantic convention registry");
1417 +         RegistryRepo::try_new(/* std::option::Option<weaver_semconv::schema_url::SchemaUrl> */, &registry_path, /* &mut std::vec::Vec<weaver_semconv::Error> */).expect("semantic convention registry");
     |

    Checking benchmarks v0.1.0 (/home/runner/work/otel-arrow/otel-arrow/rust/otap-dataflow/benchmarks)
    Checking otap-df v0.1.0 (/home/runner/work/otel-arrow/otel-arrow/rust/otap-dataflow)
    Checking otap-df-validation v0.1.0 (/home/runner/work/otel-arrow/otel-arrow/rust/otap-dataflow/crates/validation)
For more information about this error, try `rustc --explain E0061`.

@sapatrjv sapatrjv force-pushed the dev/sapatr/referweaverbrachtoavoidopensslbuild branch 2 times, most recently from 621d7e7 to a1eedf9 Compare May 8, 2026 22:14
@sapatrjv sapatrjv force-pushed the dev/sapatr/referweaverbrachtoavoidopensslbuild branch from a1eedf9 to 42af323 Compare May 8, 2026 22:17
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.26%. Comparing base (0f3ffaf) to head (42af323).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2910      +/-   ##
==========================================
- Coverage   86.27%   86.26%   -0.01%     
==========================================
  Files         715      715              
  Lines      272067   272071       +4     
==========================================
- Hits       234715   234710       -5     
- Misses      36828    36837       +9     
  Partials      524      524              
Components Coverage Δ
otap-dataflow 87.23% <100.00%> (-0.01%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.73% <ø> (ø)
otel-arrow-go 52.45% <ø> (ø)
quiver 92.25% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants