Point to Weaver main branch to include gix fix to not build openssl on windows platform and fix tag parsing issue causing crashes in latest weaver release bit.#2910
Conversation
… gix and also fix parsing tags.
| weaver_resolved_schema = { git = "https://github.com/open-telemetry/weaver.git", tag = "v0.21.2"} | ||
| weaver_resolver = { git = "https://github.com/open-telemetry/weaver.git", tag = "v0.21.2"} | ||
| weaver_semconv = { git = "https://github.com/open-telemetry/weaver.git", tag = "v0.21.2"} | ||
| weaver_common = { git = "https://github.com/open-telemetry/weaver.git", rev = "37c645a5ebc9e0d2a68f9228205f1d7d6a32ccbc"} |
There was a problem hiding this comment.
can we ask weaver for a release instead?
There was a problem hiding this comment.
sorry, it looks like there is a new release already, but then I am wondering why we use commit hash instead of tag?
There was a problem hiding this comment.
Requested for the same but no response. It is almost 2 weeks no weaver release. Hence taking this approach. Once weaver release is done rev# will be replaced with tag#.
There was a problem hiding this comment.
@lquerel should be able to help with weaver release, if we badly need it soon
|
@sapatrjv - There are some changes in the new weaver version, for which CI is failing |
621d7e7 to
a1eedf9
Compare
… gix and also fix parsing tags.
a1eedf9 to
42af323
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2910 +/- ##
==========================================
- Coverage 86.27% 86.26% -0.01%
==========================================
Files 715 715
Lines 272067 272071 +4
==========================================
- Hits 234715 234710 -5
- Misses 36828 36837 +9
Partials 524 524
🚀 New features to boost your workflow:
|
Change Summary
What issue does this PR close?
How are these changes tested?
Search cargo tree and check on windows platform no openssl dependency.
Ran Cargo xtast check
Are there any user-facing changes?