Point to Weaver main branch to include gix fix to not build openssl on windows platform and fix tag parsing issue causing crashes in latest weaver release bit.#2910
Merged
jmacd merged 5 commits intoMay 12, 2026
Conversation
… gix and also fix parsing tags.
cijothomas
reviewed
May 8, 2026
| weaver_resolved_schema = { git = "https://github.com/open-telemetry/weaver.git", tag = "v0.21.2"} | ||
| weaver_resolver = { git = "https://github.com/open-telemetry/weaver.git", tag = "v0.21.2"} | ||
| weaver_semconv = { git = "https://github.com/open-telemetry/weaver.git", tag = "v0.21.2"} | ||
| weaver_common = { git = "https://github.com/open-telemetry/weaver.git", rev = "37c645a5ebc9e0d2a68f9228205f1d7d6a32ccbc"} |
Member
There was a problem hiding this comment.
can we ask weaver for a release instead?
Member
There was a problem hiding this comment.
sorry, it looks like there is a new release already, but then I am wondering why we use commit hash instead of tag?
Contributor
Author
There was a problem hiding this comment.
Requested for the same but no response. It is almost 2 weeks no weaver release. Hence taking this approach. Once weaver release is done rev# will be replaced with tag#.
Member
There was a problem hiding this comment.
@lquerel should be able to help with weaver release, if we badly need it soon
Member
|
@sapatrjv - There are some changes in the new weaver version, for which CI is failing |
sapatrjv
force-pushed
the
dev/sapatr/referweaverbrachtoavoidopensslbuild
branch
2 times, most recently
from
621d7e7 to
a1eedf9
Compare
… gix and also fix parsing tags.
sapatrjv
force-pushed
the
dev/sapatr/referweaverbrachtoavoidopensslbuild
branch
from
a1eedf9 to
42af323
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2910 +/- ##
=======================================
Coverage 86.26% 86.26%
=======================================
Files 715 715
Lines 272060 272064 +4
=======================================
+ Hits 234690 234700 +10
+ Misses 36846 36840 -6
Partials 524 524
🚀 New features to boost your workflow:
|
Contributor
|
We will follow up and correct the weaver dep later, after those releases stabilize. |
jmacd
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Point to Weaver main branch to include gix fix to not build openssl on windows platform and fix tag parsing issue causing crashes in latest weaver release bit.
What issue does this PR close?
Part of #2697
How are these changes tested?
Search cargo tree and check on windows platform no openssl dependency.
Ran Cargo xtast check
Are there any user-facing changes?