Skip to content

Commit

Permalink
Set up new approvers for HTTP/JVM semconv. (#138)
Browse files Browse the repository at this point in the history
Co-authored-by: Reiley Yang <[email protected]>
  • Loading branch information
jsuereth and reyang authored Jun 28, 2023
1 parent 7c1b368 commit c383883
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 8 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,12 @@
/semantic_conventions/logs/ @tigrannajaryan
/specification/logs/ @tigrannajaryan

# JVM semantic conventions approvers
/semantic_conventions/metrics/process-runtime-jvm-metrics.yaml @trask
/semantic_conventions/metrics/process-runtime-jvm-metrics-experimental.yaml @trask

# HTTP semantic conventions approvers
/semantic_conventions/metrics/http.yaml @trask
/semantic_conventions/trace/http.yaml @trask

# TODO - Add semconv area experts
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@ The documentation currently resides in the previous folders, e.g.

## TODOs

- [ ] Set up github actions
- [ ] Set up SchemaURL publication
- [ ] Set up codeowners
- [ ] Contributing.MD document
- [ ] Restructure markdown for easier consumption.

Expand Down

0 comments on commit c383883

Please sign in to comment.