Give exhaustive specification of span kinds for messaging spans #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Jun 20, 2024
joaopgrassi
approved these changes
Jun 20, 2024
lmolkova
approved these changes
Jun 20, 2024
lmolkova
reviewed
Jun 20, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This is blocked on specification changes. |
|
This is blocked on open-telemetry/opentelemetry-specification#4088. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
lmolkova
added
never stale
lmolkova
reviewed
Aug 23, 2024
lmolkova
force-pushed
the
messaging-span-kinds
branch
from
ec0bc69
to
862c1a9
Compare
joaopgrassi
approved these changes
Sep 5, 2024
trask
approved these changes
Sep 16, 2024
drewby
pushed a commit
to drewby/otel-semantic-conventions
that referenced
this pull request
Oct 1, 2024
…-telemetry#1171) Co-authored-by: Liudmila Molkova <[email protected]> Co-authored-by: Joao Grassi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1112, #1366
Changes
For certain cases, messaging semantic conventions leave the span kind for
publishandprocessspans unspecified. This is not desirable, as it can lead to inconsistent span kinds between different implementations of semantic conventions.For all unspecified cases, this PR defines a span kind of type
CLIENTforpublishandSERVERforprocessspans.Merge requirement checklist
[chore]schema-next.yaml updated with changes to existing conventions.