Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate tls.client.server_name attribute in favor of common server.address #1216

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Deprecate tls.client.server_name attribute in favor of common server.address #1216

merged 6 commits into from
Jul 22, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Jul 8, 2024 •
edited
Loading

Fixes #1211

Merge requirement checklist

@lmolkova lmolkova requested review from a team July 8, 2024 18:36
@lmolkova lmolkova enabled auto-merge (squash) July 22, 2024 15:06
@lmolkova lmolkova merged commit 06b0b62 into open-telemetry:main Jul 22, 2024
11 of 12 checks passed
@joaopgrassi joaopgrassi mentioned this pull request Jul 23, 2024
Merged
maryliag pushed a commit to maryliag/semantic-conventions that referenced this pull request Jul 30, 2024
@lmolkova @joaopgrassi @maryliag
Deprecate tls.client.server_name attribute in favor of common `serv…
dc21e82 
…er.address` (open-telemetry#1216)

Co-authored-by: Joao Grassi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trisch-me trisch-me trisch-me approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could we remove tls.client.server_name in favor of server.address
4 participants
@lmolkova @joaopgrassi @trisch-me @AlexanderWert