Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove SHOULD for compiler name in process.runtime.name. #1221

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

breedx-splk
Copy link
Contributor

It seems a bit misleading to generally recommend that compiled languages include the native compiler name as the process.runtime.name attribute. With golang as a notable exception (due to the runtime being a compilation byproduct), I don't think the compiler names make much sense here otherwise.

If the specific compiler details are important to have in telemetry, then they should get their own first-class attributes, rather than piggy-backing on process.runtime.name.

I couldn't find any other support for this in the semconv nor rust nor cpp implementations. I think the behavior described below for Go is perfectly reasonable and I left it untouched.

Changes

Removes the SHOULD recommendation for including the compiler name in the process.runtime.name.

Merge requirement checklist

@breedx-splk breedx-splk requested review from a team July 9, 2024 22:05
@breedx-splk breedx-splk requested a review from a team July 9, 2024 22:13
@lmolkova
Copy link
Contributor

lmolkova commented Jul 9, 2024

/cc @open-telemetry/semconv-security-approvers @open-telemetry/semconv-system-approvers

@lmolkova lmolkova merged commit f17a4bf into open-telemetry:main Jul 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants