Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QUIC to the list of well known network transports #1239

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Jul 11, 2024

Fixes #1237

Changes

QUIC is a transport-level protocol based on UDP.

QUIC (/kwɪk/) is a general-purpose[1] transport layer[2] network protocol

It's worth adding it to the list of well-know values of network.transport.

Adding it as experimental with assumption that nothing stable depends on it.

Given it's a well-recognized name listed in RFC, it does not seem to be a problem to stabilize the constant name whenever the need comes.

Merge requirement checklist

@lmolkova lmolkova requested review from a team July 11, 2024 20:58
@lmolkova lmolkova requested a review from a team July 11, 2024 20:59
@lmolkova lmolkova merged commit 17decc3 into open-telemetry:main Jul 15, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Figure out how to map QUIC to network.* attributes
6 participants