-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container labels field from ECS #125
Add container labels field from ECS #125
Conversation
865c663
to
52ceb1c
Compare
80144e7
to
918491f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@open-telemetry/specs-semconv-approvers @open-telemetry/specs-semconv-maintainers could we have some more reviews on this? Otherwise we could merge if no objection? |
Thanks for the reviews folks! Anything else missing here? |
Signed-off-by: ChrsMark <[email protected]>
dcc04c5
to
957bbc6
Compare
@ChrsMark I just looked into https://www.elastic.co/guide/en/ecs/current/ecs-container.html#field-container-labels and there it says: "Image labels.". But in the PR here you say these are container labels, and not image. Is this intended? Wouldn't that contradict ECS? 🤔 |
@joaopgrassi Sorry Christos is out on vacation this week. I think in ECS |
This PR is part of #72 and adds the
container.lables.<key>
similarly to http-request-and-response-headers.Note that these labels refer to the container labels themselves and not the container's image labels. For image labels we would need to attach them under
container.image.labels.*
instead but for now there is no specific need for populating these too.Note also that I had to manually update the markdown table cause themake table-generation
command was failing with the following:Invalid id labels.<key>. Semantic Convention ids MUST match ([a-z](\.?[a-z0-9_-]+)+) - @35:9 make: *** [Makefile:77: table-generation] Error 1
It seems that the http-headers table was created manually too.cc: @AlexanderWert @kaiyan-sheng @mlunadia