Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nodejs.eventloop.time metric #1259

Merged
merged 12 commits into from
Aug 15, 2024
Merged

add nodejs.eventloop.time metric #1259

merged 12 commits into from
Aug 15, 2024

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Jul 16, 2024 •
edited
Loading

Changes

Adding nodejs.eventloop.time metric to a counter.
Feedback came during prototype of the nodejs runtime metrics here.

Merge requirement checklist

@maryliag maryliag requested review from a team July 16, 2024 15:53
@maryliag
Copy link
Contributor Author

cc @open-telemetry/javascript-approvers

@maryliag maryliag mentioned this pull request Jul 16, 2024
Merged
@maryliag maryliag changed the title update nodejs.eventloop.utilization type add nodejs.eventloop.time metric Jul 18, 2024
lmolkova
lmolkova reviewed Jul 23, 2024
View reviewed changes
model/metrics/nodejs-metrics.yaml Outdated Show resolved Hide resolved
model/metrics/nodejs-metrics.yaml Outdated Show resolved Hide resolved
model/metrics/nodejs-metrics.yaml Outdated Show resolved Hide resolved
model/metrics/nodejs-metrics.yaml Outdated Show resolved Hide resolved
model/registry/nodejs.yaml Outdated Show resolved Hide resolved
@maryliag maryliag requested review from a team July 30, 2024 17:36
@maryliag maryliag force-pushed the nodejs-update-utilization-runtime branch from 7f4bbcd to 43248e7 Compare July 30, 2024 18:00
lmolkova
lmolkova approved these changes Jul 31, 2024
View reviewed changes
model/metrics/nodejs-metrics.yaml Outdated Show resolved Hide resolved
@maryliag maryliag force-pushed the nodejs-update-utilization-runtime branch from c5cbb3b to 92541ea Compare July 31, 2024 21:48
@lmolkova lmolkova merged commit b6793e2 into open-telemetry:main Aug 15, 2024
12 of 13 checks passed
@maryliag maryliag deleted the nodejs-update-utilization-runtime branch August 15, 2024 12:23
ezimuel pushed a commit to ezimuel/semantic-conventions that referenced this pull request Aug 20, 2024
@maryliag @lmolkova @ezimuel
add nodejs.eventloop.time metric (open-telemetry#1259)
03b67bf 
Co-authored-by: Liudmila Molkova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-childs-docusign ben-childs-docusign ben-childs-docusign left review comments

@lmolkova lmolkova lmolkova approved these changes

@david-luna david-luna david-luna approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees

@joaopgrassi joaopgrassi

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maryliag @jsuereth @david-luna @lmolkova @ben-childs-docusign @joaopgrassi