Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update scripts to detect macos or linux for GNU sed usage #1267

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

adrielp
Copy link
Contributor

@adrielp adrielp commented Jul 20, 2024

Changes

Adding some basic OS detection in scripts and make due to the difference between sed on MacOs and Linux. Namely, gsed (GNU Sed) will be used on MacOs. The contributing guide documents the install under pre-reqs and gives the brew bundle command as an optional way to install gsed on Mac. This is simply a quality of life improvement for those on Mac.

Merge requirement checklist

@adrielp adrielp requested review from a team July 20, 2024 13:02
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

CONTRIBUTING.md Outdated Show resolved Hide resolved
@lmolkova lmolkova enabled auto-merge (squash) July 22, 2024 15:20
@lmolkova lmolkova merged commit 21b8f46 into open-telemetry:main Jul 22, 2024
11 of 12 checks passed
maryliag pushed a commit to maryliag/semantic-conventions that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants