[chore] update scripts to detect macos or linux for GNU sed usage #1267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding some basic OS detection in scripts and
make
due to the difference betweensed
on MacOs and Linux. Namely,gsed
(GNU Sed) will be used on MacOs. The contributing guide documents the install under pre-reqs and gives thebrew bundle
command as an optional way to installgsed
on Mac. This is simply a quality of life improvement for those on Mac.Merge requirement checklist
[chore]