-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to use weaver for code generation #1296
Merged
lmolkova
merged 9 commits into
open-telemetry:main
from
lmolkova:update-code-generation-to-weaver
Aug 1, 2024
Merged
Update docs to use weaver for code generation #1296
lmolkova
merged 9 commits into
open-telemetry:main
from
lmolkova:update-code-generation-to-weaver
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks for putting it together!
Left a few suggestions.
lquerel
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice documentation.
Co-authored-by: Joao Grassi <[email protected]> Co-authored-by: Laurent Quérel <[email protected]>
lmolkova
force-pushed
the
update-code-generation-to-weaver
branch
from
July 30, 2024 18:32
0d430de
to
bd3d35e
Compare
joaopgrassi
approved these changes
Jul 31, 2024
jsuereth
approved these changes
Jul 31, 2024
Co-authored-by: Joao Grassi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates code generation supplementary guidelines to use weaver instead of build-tools.
Adds a section on migration.
See open-telemetry/build-tools#322 for the context.