Add a datacenter resource. #1413
Conversation
hdost
force-pushed
the
feat/1458-adding-datacenter-convention
branch
from
1ae444e
to
eb6b348
Compare
|
|
||
| # Datacenter | ||
|
|
||
| ## Datacenter Attributes |
There was a problem hiding this comment.
We have tooling to autogenerate markdown, you should use <!-- semconv datacenter --> here for consistency.
See: https://github.com/open-telemetry/semantic-conventions/blob/main/model/README.md
There was a problem hiding this comment.
🤔 I used the automated tool. I wonder if because the name was missing this resulted.
There was a problem hiding this comment.
Well I found out what the issue was, perhaps I missed it in my reading of the various documentation, but I didn't see any mention that you need to first manually create a file which has the reference which you are mentioning, and then it will replace the contents between. I can understand the use, but it's not exactly clear as a first time user of the weaver tool.
model/datacenter/resources.yaml
Outdated
| @@ -0,0 +1,15 @@ | |||
| groups: | |||
| - id: datacenter | |||
There was a problem hiding this comment.
This needs a name field, set it to datacenter for now
hdost
force-pushed
the
feat/1458-adding-datacenter-convention
branch
3 times, most recently
from
2369cb4
to
01b85e3
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This is a bit of an anti pattern ... stale because i haven't received a review? Also check failure is unrelated to this change. |
The purpose of this is to allow for people running in a hybrid environment.
hdost
force-pushed
the
feat/1458-adding-datacenter-convention
branch
from
10b7e40
to
48cfd1c
Compare
| <!-- NOTE: THIS FILE IS AUTOGENERATED. DO NOT EDIT BY HAND. --> | ||
| <!-- see templates/registry/markdown/attribute_namespace.md.j2 --> | ||
|
|
||
| # DC |
There was a problem hiding this comment.
Not sure it is a good idea to use the abbreviation here. I'd be more inclined to go with "Data Center" instead.
| - id: dc.site | ||
| type: string | ||
| stability: experimental | ||
| brief: 'Name of the datacenter site' | ||
| note: > | ||
| The name of the physical building. | ||
| examples: ['site-1'] | ||
| - id: dc.suite | ||
| type: string | ||
| stability: experimental | ||
| brief: 'Name of the datacenter suite' | ||
| note: > | ||
| Typically the room in the building where the server cages are located. | ||
| examples: ['suite-5'] |
There was a problem hiding this comment.
this is a good case to reuse future geo namespace #1116
I'd postpone adding those two since physical address is not a datacenter-specific thing and we need to be able to express it in a generic way.
There was a problem hiding this comment.
This is not necessarily related to geolocation it's relative to the building it's in.
| stability: experimental | ||
| brief: 'Type of datacenter' | ||
| examples: ['cloud', 'colocation', 'internal'] | ||
| - id: dc.device.type |
There was a problem hiding this comment.
we already have a few attributes that can describe a device id/name #1474 - is there some we can reuse instead of adding a new one?
There was a problem hiding this comment.
I could see a scenario where you might need both a device ID and a hw component id in a parent child relationship. Maybe a server with a network card which you're measuring tx/rx.
| - id: dc.cage | ||
| type: string | ||
| stability: experimental | ||
| brief: 'Name of the cage' |
There was a problem hiding this comment.
Is this a standard property described somewhere we can link to? Also, let's add an additional layer saying what it is. E.g. dc.cage.name or dc.cage.id so that there is a room to record different properties of the cage and also the attribute name is descriptive.
There was a problem hiding this comment.
I can multiply it. I could see people using one, either , both.
| note: > | ||
| This is a literal cage which is used to protect servers from potential intruders. | ||
| examples: ['cage-1'] | ||
| - id: dc.pod |
There was a problem hiding this comment.
same as for the cage - please link some external documentation and also update the name to be more specific (dc.pod.name, or dc.pod.id or something else)
| note: > | ||
| This is a grouping of many servers typically several racks of servers. | ||
| examples: ['pod-4'] | ||
| - id: dc.chassis |
There was a problem hiding this comment.
same here, please link docs and provide specific property in the name
| type: resource | ||
| name: dc | ||
| brief: > | ||
| Generic DataCenter infrastructure tagging. |
There was a problem hiding this comment.
I think we should call out that it's intended for the telemetry that describes datacenters themselves (and not the user code running somewhere that data center)
| brief: > | ||
| Generic DataCenter infrastructure tagging. | ||
| attributes: | ||
| - id: dc.name |
There was a problem hiding this comment.
it may be better to spell this out, check out the attribute name abbreviation guidelines
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
The purpose of this is to allow for people running in a hybrid environment.
Relates #1409
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]