-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructured feature flag semconv #151
Merged
reyang
merged 3 commits into
open-telemetry:main
from
AlexanderWert:md-restruct-feature-flags
Jul 3, 2023
Merged
Restructured feature flag semconv #151
reyang
merged 3 commits into
open-telemetry:main
from
AlexanderWert:md-restruct-feature-flags
Jul 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderWert
force-pushed
the
md-restruct-feature-flags
branch
2 times, most recently
from
July 1, 2023 14:51
e84a641
to
f70fa4e
Compare
joaopgrassi
approved these changes
Jul 3, 2023
AlexanderWert
force-pushed
the
md-restruct-feature-flags
branch
from
July 3, 2023 15:24
f70fa4e
to
1525a32
Compare
Signed-off-by: Alexander Wert <[email protected]>
AlexanderWert
force-pushed
the
md-restruct-feature-flags
branch
from
July 3, 2023 16:19
1525a32
to
8900b24
Compare
reyang
approved these changes
Jul 3, 2023
reyang
reviewed
Jul 3, 2023
@@ -10,6 +10,7 @@ Semantic Conventions are defined for the following areas: | |||
* [Exceptions](exceptions/README.md): Semantic Conventions for Exceptions. | |||
* [FaaS](faas/README.md): Semantic Conventions for Function as a Service (FaaS) operations. | |||
* [CloudEvents](cloudevents/README.md): Semantic Conventions for the CloudEvents specification. | |||
* [Feature Flags](http/README.md): Semantic Conventions for feature flag evaluations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this!
Fixing it in #158.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #137
Depends on #141