feat: Add Browser click event #2992
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: browser | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Add `event.browser.user_action` to capture user action events in the browser | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [2992] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,3 +50,54 @@ groups: | |
| This value is intended to be taken from the Navigator API | ||
| `navigator.language`. | ||
| examples: ["en", "en-US", "fr", "fr-FR"] | ||
| - id: browser.page.x | ||
| type: int | ||
| stability: development | ||
| brief: 'Click x (horizontal) coordinates (in pixels) relative to the entire document.' | ||
| examples: [10] | ||
| - id: browser.page.y | ||
| type: int | ||
| stability: development | ||
| brief: 'Click y (vertical) coordinates (in pixels) relative to the entire document.' | ||
| examples: [10] | ||
|
Comment on lines
+53
to
+62
Contributor
There was a problem hiding this comment. Have we considered using https://opentelemetry.io/docs/specs/semconv/registry/attributes/app/#app-screen-coordinate-x etc |
||
| - id: browser.tag_name | ||
| type: string | ||
| stability: development | ||
| brief: 'Target element tag name obtained via event.target.tagName.' | ||
| examples: ['BUTTON'] | ||
|
Comment on lines
+63
to
+67
Contributor
There was a problem hiding this comment. |
||
| - id: browser.element.attributes | ||
| type: template[string] | ||
| stability: development | ||
| brief: 'Map of data-otel-* attributes from the target element.' | ||
| note: > | ||
| Key is the attribute name after "data-otel-" and value is the attribute value. Example: | ||
| `<button data-otel-id="testBtn" data-otel-role="submit">` | ||
| SHOULD be recorded as `browser.element.attributes.id = "testBtn"` | ||
| and `browser.element.attributes.role = "submit"`. | ||
| examples: ["testBtn", "submit"] | ||
| - id: browser.css_selector | ||
| type: string | ||
| stability: development | ||
| brief: 'Target element CSS Selector' | ||
| examples: ["#main > div:nth-child(2) > button.submit"] | ||
| note: > | ||
| Value SHOULD be a CSS selector that uniquely identifies the target element within the document. | ||
| Value SHOULD be escaped using CSS.escape() to avoid issues with special characters. | ||
| - id: hw.mouse.button | ||
| type: | ||
| members: | ||
| - id: left | ||
| value: 'left' | ||
| brief: Left button | ||
| stability: development | ||
| - id: middle | ||
| value: 'middle' | ||
| brief: Middle button | ||
| stability: development | ||
| - id: right | ||
| value: 'right' | ||
| brief: Right button | ||
| stability: development | ||
| stability: development | ||
| brief: 'User friendly name of the mouse button pressed. See [MouseEvent.buttons](https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/buttons#value).' | ||
| examples: ["left"] | ||
|
Comment on lines
+86
to
+103
Contributor
There was a problem hiding this comment. These should be in the registry file in the hardware folder. But only make the change once the triage:accepted label has been added. |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.