Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename metrics jvm.memory.usage to jvm.memory.used and jvm.memory.usage_after_last_gc to jvm.memory.used_after_last_gc #536

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Rename metrics jvm.memory.usage to jvm.memory.used and jvm.memory.usage_after_last_gc to jvm.memory.used_after_last_gc #536

merged 3 commits into from
Nov 20, 2023

Conversation

trask
Copy link
Member

@trask trask commented Nov 17, 2023

Fixes #288

Changes

Renames metrics jvm.memory.usage to jvm.memory.used and jvm.memory.usage_after_last_gc to jvm.memory.used_after_last_gc

Merge requirement checklist

@trask trask marked this pull request as ready for review November 17, 2023 03:05
@trask trask requested review from a team November 17, 2023 03:05
@joaopgrassi joaopgrassi merged commit 126059d into open-telemetry:main Nov 20, 2023
9 checks passed
@trask trask deleted the jvm-memory-used branch November 21, 2023 00:42
pyohannes pushed a commit to pyohannes/semantic-conventions that referenced this pull request Jan 17, 2024
@trask @AlexanderWert
@joaopgrassi @pyohannes
Rename metrics jvm.memory.usage to jvm.memory.used and `jvm.memor…
1babdfa 
…y.usage_after_last_gc` to `jvm.memory.used_after_last_gc` (open-telemetry#536)

Co-authored-by: Alexander Wert <[email protected]>
Co-authored-by: Joao Grassi <[email protected]>
@lenin-jaganathan lenin-jaganathan mentioned this pull request Jul 26, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@jack-berg jack-berg jack-berg approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

Assignees

@reyang reyang

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use consistent suffix for JVM Metrics
6 participants
@trask @AlexanderWert @joaopgrassi @jack-berg @mateuszrzeszutek @reyang