Skip to content

Ignore superseded dashboard publish cancellations#62

Merged
trask merged 2 commits into
open-telemetry:mainfrom
trask:ignore-superseded-dashboard-publish-cancellations
Jul 9, 2026
Merged

Ignore superseded dashboard publish cancellations#62
trask merged 2 commits into
open-telemetry:mainfrom
trask:ignore-superseded-dashboard-publish-cancellations

Conversation

@trask

@trask trask commented Jul 9, 2026

Copy link
Copy Markdown
Member

Treat cancelled per-repository dashboard runs as non-failures for hourly backfill notification purposes, so superseded publish jobs do not open noisy workflow failure issues while real failures still report.

Copilot AI review requested due to automatic review settings July 9, 2026 15:59
@trask trask requested a review from a team as a code owner July 9, 2026 15:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes a targeted one-line change to the hourly Pull Request Dashboard workflow's failure-notification gate. Previously, the notify-hourly-failure job treated only a success result from the per-repository run-repo-dashboard matrix job as a non-failure. Because the called publish-dashboard job uses concurrency with cancel-in-progress: true, a run that is superseded by a newer publish surfaces as cancelled, which was incorrectly flagged as a failure and opened noisy workflow-failure tracking issues. The change now also treats cancelled as a non-failure. Genuine failures still report, since matrix result aggregation reports failure in preference to cancelled.

Changes:

  • Treat a cancelled result from run-repo-dashboard as success for hourly backfill failure notifications, alongside success.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pull-request-dashboard.yml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@trask trask enabled auto-merge (squash) July 9, 2026 16:45
@trask trask merged commit 4e65a4b into open-telemetry:main Jul 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants