-
Notifications
You must be signed in to change notification settings - Fork 16
BGP Monitoring Protocol ( emulation of BMP Monitor ) support. #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial structure based review comments.
…ficant change and some initial changes for set_config as well
…e RFC term and more commonly used in vendor CLI as well. Monitor is sometimes uses interchange-ably in documentation and but switching to use Server throughout the model instead for better technical accuracy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine
type: boolean | ||
default: false | ||
x-field-uid: 3 | ||
name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may need to add other properties in this object in future. As the mandatory field it's better to start with the 'name' of the object that's remains at first where other properties are added in future at the end.
type: boolean | ||
default: false | ||
x-field-uid: 3 | ||
name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above.
type: object | ||
required: [name,client_ip] | ||
properties: | ||
client_ip: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't one BMP sever not able to get routing information from multiple BGP Routers?
WIP
Redocli view of proposed model
Features of the proposed model for configuring test port as a BMP Server and testing DUT configured as a BMP Client :
set_config/device/bmp
For telemetry to check DUT behaviour , exposes the following :
The gnmi yang model for BMP for access of counters/state telemetry for BMP using GNMI is expected to be near identical in approach and attribute list.
Notes:
Some known test use-cases which are currently Work In Progress but useful to consider during review phase:
BMP-1.1: BMP Session Establishment and Telemetry Test
BMP-1.2: BMP Route Monitoring with Routing Changes Test
gosnappi example BMP configuration
Json structure for BMP configuration:
Snappi python example for BMP configuration: