-
Notifications
You must be signed in to change notification settings - Fork 16
BGP Monitoring Protocol ( emulation of BMP Monitor ) support. #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
apratimmukherjee
wants to merge
45
commits into
master
Choose a base branch
from
bmp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apratimmukherjee
commented
Aug 6, 2025
Contributor
Author
apratimmukherjee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial structure based review comments.
…ficant change and some initial changes for set_config as well
…e RFC term and more commonly used in vendor CLI as well. Monitor is sometimes uses interchange-ably in documentation and but switching to use Server throughout the model instead for better technical accuracy.
SouravSinhaRoy
approved these changes
Aug 20, 2025
SuryyaKrJana
approved these changes
Aug 22, 2025
Contributor
SuryyaKrJana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine
…ics + redesigned prefix storage controls in set_config to allow for selective prefix storage amongst millions of routes + moved 'name' attribute to first element in object as per earlier review comments. There are breaking changes in this commit from previous design in route storage specification ( attribute removed and new design added ) + xuid changes due to shifting of name field to top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Redocli view of proposed model
Features of the proposed model for configuring test port as a BMP Server and testing DUT configured as a BMP Client :
set_config/device/bmp
For telemetry to check DUT behaviour , exposes the following :
The gnmi yang model for BMP for access of counters/state telemetry for BMP using GNMI is expected to be near identical in approach and attribute list.
Notes:
Some known test use-cases which are currently Work In Progress but useful to consider during review phase:
BMP-1.1: BMP Session Establishment and Telemetry Test
BMP-1.2: BMP Route Monitoring with Routing Changes Test
gosnappi example BMP configuration
Json structure for BMP configuration:
{ "ports": [ { "location": "eth1", "name": "p1" } ], "devices": [ { "ethernets": [ { "connection": { "choice": "port_name", "port_name": "p1" }, "ipv4_addresses": [ { "gateway": "1.1.1.1", "address": "1.1.1.2", "prefix": 4, "name": "p1.dev1.eth.ipv4" } ], "mac": "00:00:01:01:01:01", "mtu": 1500, "name": "p1.dev1.eth" } ], "name": "p1.dev1", "bmp": { "ipv4_interfaces": [ { "ipv4_name": "p1.dev1.eth.ipv4", "servers": [ { "client_ip": "1.1.1.1", "name": "p1.dev1.bmp" } ] } ] } } ] }Snappi python example for BMP configuration:
To use snappi dev branch corresponding to this proposed model:
go get github.com/open-traffic-generator/snappi/gosnappi@bmp